From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756897Ab3EGKWI (ORCPT ); Tue, 7 May 2013 06:22:08 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:48436 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756497Ab3EGKWF (ORCPT ); Tue, 7 May 2013 06:22:05 -0400 X-AuditID: cbfee61a-b7fd56d0000022fd-b9-5188d5cc4dc0 From: Tomasz Figa To: Zhang Rui Cc: Amit Daniel Kachhap , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, Kukjin Kim , Eduardo Valentin Subject: Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory Date: Tue, 07 May 2013 12:21:42 +0200 Message-id: <1927845.etOFu5Zfbm@amdc1227> Organization: Samsung Poland R&D Center User-Agent: KMail/4.10.2 (Linux/3.8.3-gentoo-r1; KDE/4.10.2; x86_64; ; ) In-reply-to: <1367852706.2079.57.camel@rzhang1-mobl4> References: <1366972671-9227-1-git-send-email-amit.daniel@samsung.com> <1366972671-9227-2-git-send-email-amit.daniel@samsung.com> <1367852706.2079.57.camel@rzhang1-mobl4> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsVy+t9jAd0zVzsCDdYv4bFouBpi8evdTHaL Nft/Mln0LrjKZnF51xw2i8+9RxgtZpzfx2Tx5GEfmwOHx85Zd9k9Fu95yeTRt2UVo8fxG9uZ PD5vkgtgjeKySUnNySxLLdK3S+DK2Pm9gb1gg3pF39KHjA2M8+W7GDk5JARMJM4fOMQCYYtJ XLi3nq2LkYtDSGARo8Tmd3NZIJwWJomTX+YwglSxCahJfG54xAZiiwgoSyw6txUszizwi1Fi 7yVWEFtYIFlix8NVYDUsAqoSn5t+A8U5OHgFNCWa5keAhPkF1CXebXvKBBIWFfCQuHeTCSTM KWAqMaP5GNTadYwSLTPegR3HKyAo8WPyPRaIVfIS+/ZPZYWwtSTW7zzONIFRcBaSsllIymYh KVvAyLyKUTS1ILmgOCk911CvODG3uDQvXS85P3cTIzgKnkntYFzZYHGIUYCDUYmHV+FUe6AQ a2JZcWXuIUYJDmYlEd4bBzsChXhTEiurUovy44tKc1KLDzFKc7AoifMeaLUOFBJITyxJzU5N LUgtgskycXBKNTBab2VfoL1o0jlOFln3Y5p3Zlov+R+4/qqea16TnJT/pPOu35LkJly4vvHm lsvlkRt+PN/e2VAdc7/JV+XU9hV3xf/8/jen65yDnWfgoe1fFgdes1OYZGHFy7zlNCf/bcmW ILUFiY1Hj1vl5+cuOs09beV2vrC95wKfPjB0uPFyyceWMP3cg/93KbEUZyQaajEXFScCABdA hsN+AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 06 of May 2013 23:05:06 Zhang Rui wrote: > On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > > This movement of files is done for easy maintenance and adding more > > new sensor's support for exynos platform easily . This will also help in > > bifurcating exynos common, sensor driver and sensor data related parts. > > > > Acked-by: Kukjin Kim > > Signed-off-by: Amit Daniel Kachhap > > --- > > > > drivers/thermal/Kconfig | 13 +++++-------- > > drivers/thermal/Makefile | 2 +- > > drivers/thermal/samsung/Kconfig | 9 +++++++++ > > drivers/thermal/samsung/Makefile | 4 ++++ > > drivers/thermal/{ => samsung}/exynos_thermal.c | 0 > > 5 files changed, 19 insertions(+), 9 deletions(-) > > create mode 100644 drivers/thermal/samsung/Kconfig > > create mode 100644 drivers/thermal/samsung/Makefile > > rename drivers/thermal/{ => samsung}/exynos_thermal.c (100%) > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 5e3c025..081ddc5 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL > > > > Support for the Kirkwood thermal sensor driver into the Linux thermal > > framework. Only kirkwood 88F6282 and 88F6283 have this sensor. > > > > -config EXYNOS_THERMAL > > - tristate "Temperature sensor on Samsung EXYNOS" > > - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) > > - depends on CPU_THERMAL > > - help > > - If you say yes here you get support for TMU (Thermal Management > > - Unit) on SAMSUNG EXYNOS series of SoC. > > - > > > > config DOVE_THERMAL > > > > tristate "Temperature sensor on Marvell Dove SoCs" > > depends on ARCH_DOVE > > > > @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP > > > > enforce idle time which results in more package C-state residency. The > > user interface is exposed via generic thermal framework. > > > > +menu "Exynos thermal drivers" > > would it be more proper to use "Samsung thermal drivers" or "Samsung > Exynos thermal drivers" instead? +1 Still, I wonder if it really makes sense to create a separate directory and submenu for this. > > +depends on PLAT_SAMSUNG > > +source "drivers/thermal/samsung/Kconfig" > > +endmenu > > + > > sorry I know few about arm, > could you tell me the difference between > CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, > I do not see the dependency between these in Kconfig file? If those files were kept at thermal/, there would be no need for this check. Just particular drivers would depend on platform they are for. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Kernel and System Framework > > > endif > > > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > index c054d41..b3063a9 100644 > > --- a/drivers/thermal/Makefile > > +++ b/drivers/thermal/Makefile > > @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o > > > > obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o > > obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o > > obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o > > > > -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o > > +obj-y += samsung/ > > > > obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o > > obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o > > obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o > > > > diff --git a/drivers/thermal/samsung/Kconfig > > b/drivers/thermal/samsung/Kconfig new file mode 100644 > > index 0000000..2d3d9dc > > --- /dev/null > > +++ b/drivers/thermal/samsung/Kconfig > > @@ -0,0 +1,9 @@ > > +config EXYNOS_THERMAL > > + tristate "Temperature sensor on Samsung EXYNOS" > > + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) > > + depends on CPU_THERMAL > > + help > > + If you say yes here you get support for TMU (Thermal Management > > + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering > > + the exynos thermal driver with the core thermal layer and cpu > > + cooling API's. > > diff --git a/drivers/thermal/samsung/Makefile > > b/drivers/thermal/samsung/Makefile new file mode 100644 > > index 0000000..1fe6d93 > > --- /dev/null > > +++ b/drivers/thermal/samsung/Makefile > > @@ -0,0 +1,4 @@ > > +# > > +# Samsung thermal specific Makefile > > +# > > +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o > > diff --git a/drivers/thermal/exynos_thermal.c > > b/drivers/thermal/samsung/exynos_thermal.c similarity index 100% > > rename from drivers/thermal/exynos_thermal.c > > rename to drivers/thermal/samsung/exynos_thermal.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html