public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ankan Biswas <spyjetfayed@gmail.com>
To: bbrezillon@kernel.org, himal.prasad.ghimiray@intel.com,
	dakr@kernel.org, matt.coster@imgtec.com,
	robin.clark@oss.qualcomm.com, matthew.brost@intel.com,
	aliceryhl@google.com, thomas.hellstrom@linux.intel.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, simona@ffwll.ch, skhan@linuxfoundation.org,
	khalid@kernel.org, david.hunter.linux@gmail.com,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev,
	dri-devel@lists.freedesktop.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v2] drm/gpuvm: Fix kernel-doc warning for drm_gpuvm_map_req.map
Date: Wed, 15 Oct 2025 21:06:58 +0530	[thread overview]
Message-ID: <192bc74d-90d8-45ae-a324-6c29ccae2a06@gmail.com> (raw)
In-Reply-To: <20251015113656.21447-1-spyjetfayed@gmail.com>



On 10/15/25 6:56 PM, Matt Coster wrote:
 > On 15/10/2025 12:31, Ankan Biswas wrote:
 >> The kernel-doc for struct drm_gpuvm_map_req.map was added as '@op_map'
 >> instead of '@map', leading to this warning during htmldocs build:
 >>
 >> WARNING: include/drm/drm_gpuvm.h:1083 struct member 'map' not 
described in 'drm_gpuvm_map_req'
 >>
 >> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
 >> Reported-by: Stephen Rothwell<sfr@canb.auug.org.au>
 >> Signed-off-by: Ankan Biswas<spyjetfayed@gmail.com>
 > Hi Ankan,
 >
 > Thanks for the fix! Is there a public report from Stephen that you can
 > link to with a Closes: tag after the Reported-by: tag (see [1])?

Hi Matt

Thanks for pointing that out, I have added the Closes tag for v3.
And resent it.

 >
 > Otherwise, this looks good to me and I'll be happy to R-b and take it
 > via drm-misc-fixes.


On 10/15/25 7:09 PM, Danilo Krummrich wrote:
 > On 10/15/25 1:31 PM, Ankan Biswas wrote:
 >> The kernel-doc for struct drm_gpuvm_map_req.map was added as '@op_map'
 >> instead of '@map', leading to this warning during htmldocs build:
 >>
 >> WARNING: include/drm/drm_gpuvm.h:1083 struct member 'map' not 
described in 'drm_gpuvm_map_req'
 >>
 >> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
 >> Reported-by: Stephen Rothwell<sfr@canb.auug.org.au>
 > Please add a Closes: tag, checkpatch.pl should warn about this.
 >
 > Thanks,
 > Danilo

Hi Danilo,

My bad, I did not use checkpatch.pl before sending, I didn't know
it also caught missing tags. Thanks for mentioning it.


Best Regards,
Ankan Biswas

      parent reply	other threads:[~2025-10-15 15:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 11:31 [PATCH v2] drm/gpuvm: Fix kernel-doc warning for drm_gpuvm_map_req.map Ankan Biswas
2025-10-15 13:26 ` Matt Coster
2025-10-15 13:39 ` Danilo Krummrich
2025-10-15 15:36 ` Ankan Biswas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=192bc74d-90d8-45ae-a324-6c29ccae2a06@gmail.com \
    --to=spyjetfayed@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bbrezillon@kernel.org \
    --cc=dakr@kernel.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=khalid@kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=matthew.brost@intel.com \
    --cc=mripard@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox