linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: hugo lee <cs.hugolee@gmail.com>
Cc: Sean Christopherson <seanjc@google.com>,
	pbonzini@redhat.com,  tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com,  hpa@zytor.com,
	x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Yuguo Li <hugoolli@tencent.com>
Subject: Re: [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split
Date: Thu, 14 Aug 2025 11:10:35 +0200	[thread overview]
Message-ID: <193779d766e08f4e013326da9f1de9de5e030398.camel@infradead.org> (raw)
In-Reply-To: <CAAdeq_JQO2x=x07BwmDcTCU-WfKLW6kFk38881vbyUTehP+7gw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Thu, 2025-08-14 at 16:54 +0800, hugo lee wrote:
> On Wed, Aug 13, 2025 David Woodhouse <dwmw2@infradead.org> wrote:
> > 
> > On Wed, 2025-08-13 at 17:30 +0800, hugo lee wrote:
> > > 
> > > Sorry for the misleading, what I was going to say is
> > > do only cpu_synchroniza_state() in this new userspace exit reason
> > > and do nothing on the PIT.
> > > So QEMU will ignore the PIT as the guests do.
> > > 
> > > The resample is great and needed, but the synchronization
> > > makes more sense to me on this question.
> > 
> > So if the guest doesn't actually quiesce the PIT, QEMU will *still*
> > keep waking up to waggle the PIT output pin, it's just that QEMU won't
> > bother telling the kernel about it?
> 
> Yes, just as guests wish.
> This could eliminate the most performance loss.
> 
> But I guess resample is more acceptable.

Simpler, cleaner, solves it for more use cases including when the
interrupt *is* delivered to the PIC but just never services. And allows
us to fix the VFIO INTx abomination and use the kernel's irqfd API
properly...

But that's a discussion for the qemu-devel list, I suppose.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]

      reply	other threads:[~2025-08-14  9:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  8:10 [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split Yuguo Li
2025-08-06 18:20 ` Sean Christopherson
2025-08-07  8:03   ` hugo lee
2025-08-07 18:38     ` Sean Christopherson
2025-08-08  2:46       ` hugo lee
2025-08-11 16:32         ` Sean Christopherson
2025-08-12  9:39           ` David Woodhouse
2025-08-12 10:18             ` hugo lee
2025-08-12 10:08           ` hugo lee
2025-08-12 10:46             ` David Woodhouse
2025-08-12 11:50               ` hugo lee
2025-08-12 12:54                 ` David Woodhouse
2025-08-13  9:30                   ` hugo lee
2025-08-13 10:03                     ` David Woodhouse
2025-08-14  8:54                       ` hugo lee
2025-08-14  9:10                         ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=193779d766e08f4e013326da9f1de9de5e030398.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=bp@alien8.de \
    --cc=cs.hugolee@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=hugoolli@tencent.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).