From: corbet@lwn.net (Jonathan Corbet)
To: David Howells <dhowells@redhat.com>
Cc: viro@ftp.linux.org.uk, hch@infradead.org,
Trond.Myklebust@netapp.com, sds@tycho.nsa.gov,
casey@schaufler-ca.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 04/22] CRED: Request a credential record for a kernel service
Date: Tue, 25 Sep 2007 13:20:21 -0600 [thread overview]
Message-ID: <19445.1190748021@lwn.net> (raw)
In-Reply-To: Your message of "Fri, 21 Sep 2007 15:47:24 BST."
Hi, David,
One little thing I noticed:
> + * @cred_kernel_act_as:
> + * Set the credentials for a kernel service to act as (subjective context).
> + * @cred points to the credentials structure to be filled in.
> + * @service names the service making the request.
> + * @daemon: A userspace daemon to be used as a base for the context.
> + * @dentry: A file or dir to be used as a base for the file creation
> + * context.
> + * Return 0 if successful.
The comment describes a "dentry" argument, but the actual function does
not have that argument.
jon
Jonathan Corbet / LWN.net / corbet@lwn.net
next reply other threads:[~2007-09-25 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 19:20 Jonathan Corbet [this message]
2007-09-25 19:27 ` [PATCH 04/22] CRED: Request a credential record for a kernel service David Howells
-- strict thread matches above, loose matches on Subject: below --
2007-09-21 14:47 [PATCH 00/22] Introduce credential record David Howells
2007-09-21 14:47 ` [PATCH 04/22] CRED: Request a credential record for a kernel service David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19445.1190748021@lwn.net \
--to=corbet@lwn.net \
--cc=Trond.Myklebust@netapp.com \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox