Re: [PATCH v13 01/19] Documentation/x86: Secure Launch kernel documentation

ross.philipson
2025-04-15T20:45:40Z

On 4/11/25 2:32 PM, 'Sean Christopherson' via trenchboot-devel wrote:
> On Fri, Apr 11, 2025, ross.philipson@oracle.com wrote:
>> On 4/10/25 10:50 PM, ALOK TIWARI wrote:
>>>
>>>
>>> On 11-04-2025 02:11, Ross Philipson wrote:
>>>> +
>>>> + - Entry from the dynamic launch jumps to the SL stub.
>>>> + - SL stub fixes up the world on the BSP.
>>>> + - For TXT, SL stub wakes the APs, fixes up their worlds.
>>>> + - For TXT, APs are left halted using MONITOR/MWAIT intructions.
>>>
>>> typo intructions -> instruction
>>
>> Thanks for the review. They are two separate instructions so is this really
>> incorrect?
>
> From the peanut gallery, I'd just drop the "instruction(s)" qualifier, i.e.
>
> - For TXT, APs are left halted using MONITOR/MWAIT.
>
> Pedantically, it's the combination of MONTIOR+MWAIT that puts the CPU into a
> sleep state, not the individual instructions.
>
> And while I'm picking nits, the documentation is also a bit misleading as the CPU
> isn't halted per se. I'd go with something like:
>
> - For TXT, APs are left in an optimized (MONITOR/MWAIT) wait state.
>
Good suggestion, thanks

Ross