* [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases
@ 2026-03-28 13:05 谢致邦 (XIE Zhibang)
2026-03-28 15:08 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: 谢致邦 (XIE Zhibang) @ 2026-03-28 13:05 UTC (permalink / raw)
To: linux-rockchip
Cc: 谢致邦 (XIE Zhibang), Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Kever Yang,
Finley Xiao, devicetree, linux-arm-kernel, linux-kernel
This fixes the stdout-path in rk3562-evb2-v10.dts.
Fixes: ceb6ef1ea900 ("arm64: dts: rockchip: Add RK3562 evb2 devicetree")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
arch/arm64/boot/dts/rockchip/rk3562.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
index e4816aa3dae0..14e74e8ac7df 100644
--- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
@@ -26,6 +26,16 @@ aliases {
gpio2 = &gpio2;
gpio3 = &gpio3;
gpio4 = &gpio4;
+ serial0 = &uart0;
+ serial1 = &uart1;
+ serial2 = &uart2;
+ serial3 = &uart3;
+ serial4 = &uart4;
+ serial5 = &uart5;
+ serial6 = &uart6;
+ serial7 = &uart7;
+ serial8 = &uart8;
+ serial9 = &uart9;
};
xin32k: clock-xin32k {
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases
2026-03-28 13:05 [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases 谢致邦 (XIE Zhibang)
@ 2026-03-28 15:08 ` Krzysztof Kozlowski
2026-03-30 2:46 ` 谢致邦 (XIE Zhibang)
2026-03-30 8:27 ` Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-28 15:08 UTC (permalink / raw)
To: 谢致邦 (XIE Zhibang), linux-rockchip
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Kever Yang, Finley Xiao, devicetree, linux-arm-kernel,
linux-kernel
On 28/03/2026 14:05, 谢致邦 (XIE Zhibang) wrote:
> This fixes the stdout-path in rk3562-evb2-v10.dts.
>
> Fixes: ceb6ef1ea900 ("arm64: dts: rockchip: Add RK3562 evb2 devicetree")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3562.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> index e4816aa3dae0..14e74e8ac7df 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> @@ -26,6 +26,16 @@ aliases {
> gpio2 = &gpio2;
> gpio3 = &gpio3;
> gpio4 = &gpio4;
> + serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + serial4 = &uart4;
> + serial5 = &uart5;
> + serial6 = &uart6;
> + serial7 = &uart7;
> + serial8 = &uart8;
> + serial9 = &uart9;
UART aliases are properties of the boards, not SoC.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases
2026-03-28 15:08 ` Krzysztof Kozlowski
@ 2026-03-30 2:46 ` 谢致邦 (XIE Zhibang)
2026-03-30 8:04 ` Krzysztof Kozlowski
2026-03-30 8:27 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: 谢致邦 (XIE Zhibang) @ 2026-03-30 2:46 UTC (permalink / raw)
To: krzk
Cc: Yeking, conor+dt, devicetree, finley.xiao, heiko, kever.yang,
krzk+dt, linux-arm-kernel, linux-kernel, linux-rockchip, robh
On Sat, Mar 28, 2026 at 04:08:57PM +0100, Krzysztof Kozlowski wrote:
> On 28/03/2026 14:05, 谢致邦 (XIE Zhibang) wrote:
> > This fixes the stdout-path in rk3562-evb2-v10.dts.
> >
> > Fixes: ceb6ef1ea900 ("arm64: dts: rockchip: Add RK3562 evb2 devicetree")
> > Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3562.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > index e4816aa3dae0..14e74e8ac7df 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > @@ -26,6 +26,16 @@ aliases {
> > gpio2 = &gpio2;
> > gpio3 = &gpio3;
> > gpio4 = &gpio4;
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + serial2 = &uart2;
> > + serial3 = &uart3;
> > + serial4 = &uart4;
> > + serial5 = &uart5;
> > + serial6 = &uart6;
> > + serial7 = &uart7;
> > + serial8 = &uart8;
> > + serial9 = &uart9;
>
> UART aliases are properties of the boards, not SoC.
>
> Best regards,
> Krzysztof
So are you saying that we need to remove the serial aliases from files
like rk3308.dtsi, rk3328.dtsi, rk3368.dtsi, rk3399-base.dtsi,
rk356x-base.dtsi, rk3576.dtsi, rk3588-base.dtsi, and so on?
Kind regards,
XIE Zhibang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases
2026-03-30 2:46 ` 谢致邦 (XIE Zhibang)
@ 2026-03-30 8:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-30 8:04 UTC (permalink / raw)
To: 谢致邦 (XIE Zhibang)
Cc: conor+dt, devicetree, finley.xiao, heiko, kever.yang, krzk+dt,
linux-arm-kernel, linux-kernel, linux-rockchip, robh
On 30/03/2026 04:46, 谢致邦 (XIE Zhibang) wrote:
> On Sat, Mar 28, 2026 at 04:08:57PM +0100, Krzysztof Kozlowski wrote:
>> On 28/03/2026 14:05, 谢致邦 (XIE Zhibang) wrote:
>>> This fixes the stdout-path in rk3562-evb2-v10.dts.
>>>
>>> Fixes: ceb6ef1ea900 ("arm64: dts: rockchip: Add RK3562 evb2 devicetree")
>>> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3562.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
>>> index e4816aa3dae0..14e74e8ac7df 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
>>> @@ -26,6 +26,16 @@ aliases {
>>> gpio2 = &gpio2;
>>> gpio3 = &gpio3;
>>> gpio4 = &gpio4;
>>> + serial0 = &uart0;
>>> + serial1 = &uart1;
>>> + serial2 = &uart2;
>>> + serial3 = &uart3;
>>> + serial4 = &uart4;
>>> + serial5 = &uart5;
>>> + serial6 = &uart6;
>>> + serial7 = &uart7;
>>> + serial8 = &uart8;
>>> + serial9 = &uart9;
>>
>> UART aliases are properties of the boards, not SoC.
>>
>> Best regards,
>> Krzysztof
>
> So are you saying that we need to remove the serial aliases from files
> like rk3308.dtsi, rk3328.dtsi, rk3368.dtsi, rk3399-base.dtsi,
> rk356x-base.dtsi, rk3576.dtsi, rk3588-base.dtsi, and so on?
Well, I tried once but people disagreed because of impact, so probably not.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases
2026-03-28 15:08 ` Krzysztof Kozlowski
2026-03-30 2:46 ` 谢致邦 (XIE Zhibang)
@ 2026-03-30 8:27 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2026-03-30 8:27 UTC (permalink / raw)
To: 谢致邦 (XIE Zhibang), linux-rockchip,
Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kever Yang,
Finley Xiao, devicetree, linux-arm-kernel, linux-kernel
Am Samstag, 28. März 2026, 16:08:57 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 28/03/2026 14:05, 谢致邦 (XIE Zhibang) wrote:
> > This fixes the stdout-path in rk3562-evb2-v10.dts.
> >
> > Fixes: ceb6ef1ea900 ("arm64: dts: rockchip: Add RK3562 evb2 devicetree")
> > Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3562.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > index e4816aa3dae0..14e74e8ac7df 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > @@ -26,6 +26,16 @@ aliases {
> > gpio2 = &gpio2;
> > gpio3 = &gpio3;
> > gpio4 = &gpio4;
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + serial2 = &uart2;
> > + serial3 = &uart3;
> > + serial4 = &uart4;
> > + serial5 = &uart5;
> > + serial6 = &uart6;
> > + serial7 = &uart7;
> > + serial8 = &uart8;
> > + serial9 = &uart9;
>
> UART aliases are properties of the boards, not SoC.
We had this argument a lot of times for those numbered aliases
where everything on all soc documentation, schematics and also
user documentation for individual boards, generally references
exactly those numbers :-)
But fiiiiiine, if it comes up all the time ...
I really hope, you're okay with intermitend ordering though:
serial0 = &uart0;
serial2 = &uart2;
serial5 = &uart5;
because otherwise, this would cause pure chaos everywhere.
Because as I said this serial number is used on board-schematics,
board-user-level documentation, SoC documentation, even silcscreen
on boards ... so everywhere.
Similar for all the numbered busses ofthe SoCs.
Heiko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-30 8:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-28 13:05 [PATCH] arm64: dts: rockchip: Add RK3562 serial aliases 谢致邦 (XIE Zhibang)
2026-03-28 15:08 ` Krzysztof Kozlowski
2026-03-30 2:46 ` 谢致邦 (XIE Zhibang)
2026-03-30 8:04 ` Krzysztof Kozlowski
2026-03-30 8:27 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox