From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbaIJITv (ORCPT ); Wed, 10 Sep 2014 04:19:51 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:52264 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbaIJITq (ORCPT ); Wed, 10 Sep 2014 04:19:46 -0400 X-AuditID: cbfee61a-f79e46d00000134f-5b-5410099ff5f9 From: Bartlomiej Zolnierkiewicz To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Guennadi Liakhovetski , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST Date: Wed, 10 Sep 2014 10:19:41 +0200 Message-id: <1959112.4FzR3bzOGa@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-54-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: <3055703.v1cXzV8T6U@amdc1032> References: <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab@samsung.com> <5f850d5d45a27c50dabf3da08689cbedf986841b.1410288748.git.m.chehab@samsung.com> <3055703.v1cXzV8T6U@amdc1032> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=ISO-8859-1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t9jAd35nAIhBgf2mFu83ziPyeLyrjls Fj0btrJaHFzYxmhxcZ28xY5Ti5gttu69yu7A7tF44wabx4ePcR6bV2h59G1ZxejxeZNcAGsU l01Kak5mWWqRvl0CV8aFM+tYCtZzVuzZ/pu1gXEvexcjJ4eEgInE4eUfoGwxiQv31rN1MXJx CAksYpToe/SfGcJpYZI4uWUqE0gVm4CVxMT2VYwgtoiAgcTjRSfZQYqYBRqZJK4svckMkhAW sJW4dHktWAOLgKrEsjl/WEBsXgFNiemv1oLZogKeEju2rwRax8HBKaAl8eyPI8Sys4wSd7dN gaoXlPgx+R6YzSwgL7Fv/1RWCFtHYn/rNLYJjAKzkJTNQlI2C0nZAkbmVYyiqQXJBcVJ6bmG esWJucWleel6yfm5mxjBIf5MagfjygaLQ4wCHIxKPLwCtfwhQqyJZcWVuYcYJTiYlUR4Z70C CvGmJFZWpRblxxeV5qQWH2KU5mBREuc90GodKCSQnliSmp2aWpBaBJNl4uCUamCc0NThmOBW I//Na9qBv961fkLB+Vatoev6EvKf3bed6cfDVPPl+ObeXbrq8w4sUl+69JBm6LmPDDPYNzov OxJm+We/okz2mb6Qu8IXg89MD5/uuo1F/PvnFwUqZ5Uf3eoVDH0RvaSxv/X+8wd3NhvzmSQ/ +JL0Um/3+5t3GDdufj7JPSLyTx+rEktxRqKhFnNRcSIAiNeUVm0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 10, 2014 10:04:12 AM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 09, 2014 03:54:04 PM Mauro Carvalho Chehab wrote: > > This driver depends on a legacy OMAP DMA API. So, it won't > > compile-test on other archs. > > > > While we might add stubs to the functions, this is not a > > good idea, as the hole API should be replaced. > > This is also not a good idea becaouse it would break the driver > for OMAP1 once somebody enables COMPILE_TEST option while also > having ARCH_OMAP1 enabled (which is perfectly fine and shouldn't > cause the driver breakage). In general COMPILE_TEST option is > completely independent from the arch specific ones and it should > not change behaviour of the existing code. Small clarification: I was of course referring to the original patch for the issue: https://lkml.org/lkml/2014/9/9/498 stubs can be added properly with using #if defined(CONFIG_COMPILE_TEST) && !defined(CONFIG_ARCH_OMAP1) similarly like it is handled for ARCH_QCOM in drivers/gpu/drm/msm/msm_drv.h Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics