From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <andrew@lunn.ch>,
<sebastian.hesselbarth@gmail.com>, <gregory.clement@bootlin.com>,
<herve.codina@bootlin.com>, <qiang.zhao@nxp.com>,
<christophe.leroy@csgroup.eu>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <nm@ti.com>, <ssantosh@kernel.org>,
<petlozup@nvidia.com>, <pshete@nvidia.com>,
<christophe.jaillet@wanadoo.fr>, <ulf.hansson@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-tegra@vger.kernel.org>, <jic23@kernel.org>
Subject: Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()
Date: Thu, 29 Aug 2024 10:25:53 +0800 [thread overview]
Message-ID: <195dd9e0-ef42-bcf8-b71a-d9d548af014a@huawei.com> (raw)
In-Reply-To: <32e8ef50-ae45-4001-92b6-1e9e0608b402@kernel.org>
On 2024/8/28 21:08, Krzysztof Kozlowski wrote:
> On 28/08/2024 03:58, Jinjie Ruan wrote:
>>
>>
>> On 2024/8/27 21:50, Krzysztof Kozlowski wrote:
>>> On 27/08/2024 13:46, Jinjie Ruan wrote:
>>>> Use the dev_err_probe() helper to simplify error handling during probe.
>>>> This also handle scenario, when EDEFER is returned and useless error
>>>> is printed.
>>>
>>> ? Sorry, this cannot happen. Please point to below code which can defer.
>>>
>>
>> Thank you!
>>
>> This is not referring to a specific one, but rather the benefits it
>> offers，simplify code is the main purpose, if necessary, it will be
>> removed in next version.
>
> It just feels like you are doing these in machine way without actually
> knowing concepts behind dev_err_probe().
Just try my best to make the code as clean as possible and do it by the way.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-08-29 2:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 11:45 [PATCH -next 0/8] soc: Simplify with scoped for each OF child loop and dev_err_probe() Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 1/8] soc: fsl: cpm1: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe() Jinjie Ruan
2024-08-27 13:50 ` Krzysztof Kozlowski
2024-08-28 1:58 ` Jinjie Ruan
2024-08-28 13:08 ` Krzysztof Kozlowski
2024-08-29 2:25 ` Jinjie Ruan [this message]
2024-08-27 11:46 ` [PATCH -next 3/8] soc: fsl: cpm1: qmc: Simplify with scoped for each OF child Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 4/8] soc: fsl: cpm1: qmc: Simplify with dev_err_probe() Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 5/8] soc/tegra: pmc: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 6/8] soc: dove: " Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 7/8] soc: ti: knav_dma: " Jinjie Ruan
2024-08-27 11:46 ` [PATCH -next 8/8] soc: ti: knav_qmss_queue: " Jinjie Ruan
2024-08-29 15:58 ` Kousik Sanagavarapu
2024-08-29 18:06 ` Nishanth Menon
2024-08-30 3:24 ` Jinjie Ruan
2024-08-31 10:30 ` Jonathan Cameron
2024-08-29 15:43 ` (subset) [PATCH -next 0/8] soc: Simplify with scoped for each OF child loop and dev_err_probe() Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=195dd9e0-ef42-bcf8-b71a-d9d548af014a@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=gregory.clement@bootlin.com \
--cc=herve.codina@bootlin.com \
--cc=jic23@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nm@ti.com \
--cc=petlozup@nvidia.com \
--cc=pshete@nvidia.com \
--cc=qiang.zhao@nxp.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox