Re: [PATCH] ASoC: Intel: avs: Fix kcalloc() sizes

["Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>]

On 2025-04-26 16:13, Thorsten Blum wrote:
> rlist, clist, and slist are allocated using sizeof(pointer) instead of
> sizeof(*pointer). Fix the allocations by using sizeof(*pointer) and
> avoid overallocating memory on 64-bit systems.
> 
> Fixes: f2f847461fb7 ("ASoC: Intel: avs: Constrain path based on BE capabilities")
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   sound/soc/intel/avs/path.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/intel/avs/path.c b/sound/soc/intel/avs/path.c
> index cafb8c6198be..8f1bf8d0af8f 100644
> --- a/sound/soc/intel/avs/path.c
> +++ b/sound/soc/intel/avs/path.c
> @@ -131,9 +131,9 @@ int avs_path_set_constraint(struct avs_dev *adev, struct avs_tplg_path_template
>   	list_for_each_entry(path_template, &template->path_list, node)
>   		i++;
>   
> -	rlist = kcalloc(i, sizeof(rlist), GFP_KERNEL);
> -	clist = kcalloc(i, sizeof(clist), GFP_KERNEL);
> -	slist = kcalloc(i, sizeof(slist), GFP_KERNEL);
> +	rlist = kcalloc(i, sizeof(*rlist), GFP_KERNEL);
> +	clist = kcalloc(i, sizeof(*clist), GFP_KERNEL);
> +	slist = kcalloc(i, sizeof(*slist), GFP_KERNEL);
>   
>   	i = 0;
>   	list_for_each_entry(path_template, &template->path_list, node) {

Of course, thanks!

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>