From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9248C48BD7 for ; Thu, 27 Jun 2019 12:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 843B920645 for ; Thu, 27 Jun 2019 12:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfF0Mmz (ORCPT ); Thu, 27 Jun 2019 08:42:55 -0400 Received: from gloria.sntech.de ([185.11.138.130]:34264 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0Mmz (ORCPT ); Thu, 27 Jun 2019 08:42:55 -0400 Received: from wf0413.dip.tu-dresden.de ([141.76.181.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgTjj-0007wm-2p; Thu, 27 Jun 2019 14:42:47 +0200 From: Heiko Stuebner To: Enric Balletbo i Serra Cc: devicetree@vger.kernel.org, Collabora Kernel ML , Felipe Balbi , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, Vicente Bergas , Klaus Goger , Christoph Muellner , Randy Li , Tony Xie , Viresh Kumar , Matthias Brugger Subject: Re: [PATCH] arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs Date: Thu, 27 Jun 2019 14:42:46 +0200 Message-ID: <1960228.jn0vabPeDx@phil> In-Reply-To: <20190613162745.12195-1-enric.balletbo@collabora.com> References: <20190613162745.12195-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 13. Juni 2019, 18:27:45 CEST schrieb Enric Balletbo i Serra: > As per binding documentation [1], the DWC3 core should have the "ref", > "bus_early" and "suspend" clocks. As explained in the binding, those > clocks are required for new platforms but not for existing platforms > before commit fe8abf332b8f ("usb: dwc3: support clocks and resets for > DWC3 core"). > > However, as those clocks are really treated as required, this ends with > having some annoying messages when the "rockchip,rk3399-dwc3" is used: > > [ 1.724107] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 > [ 1.731893] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 > [ 2.495937] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2 > [ 2.647239] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2 > > In order to remove those annoying messages, update the DWC3 hardware > module node and add all the required clocks. With this change, both, the > glue node and the DWC3 core node, have the clocks defined, but that's > not really a problem and there isn't a side effect on do this. So, we > can get rid of the annoying get clk error messages. > > [1] Documentation/devicetree/bindings/usb/dwc3.txt > > Signed-off-by: Enric Balletbo i Serra applied for 5.3 Thanks Heiko