public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Bernd Schmidt <bernds_cb1@t-online.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Wu, Bryan" <Bryan.Wu@analog.com>
Subject: Re: [PATCH, RFD]: Unbreak no-mmu mmap
Date: Wed, 01 Aug 2007 13:29:07 +0100	[thread overview]
Message-ID: <19618.1185971347@redhat.com> (raw)
In-Reply-To: <46695F6D.5050600@t-online.de>

Bernd Schmidt <bernds_cb1@t-online.de> wrote:
> 1. munmap can now unmap subparts of previously allocated blocks.  This
>    makes behaviour more consistent with mmu Linux, and allows us to
>    simplify and speed up the uClibc malloc implementation.

There's a problem with your alteration to do_munmap() to split VMAs.  What
happens if an area of a file is mmap'd twice in a process?  Consider the
situation where two independent parts of a process (say two different
libraries) each map an area of the same file.  do_mmap_pgoff() will attempt to
share these regions if it can.

This can lead to you splitting the wrong VMA when someone comes along later to 
do an apparent partial unmap.

I'm currently working on something to give each NOMMU process its own list
VMAs rather than holding them in common.  This is so that I can add VMA
reservation (and more to the point, unreservation) which'll make some stuff
easier.

David

  parent reply	other threads:[~2007-08-01 12:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-08 13:53 [PATCH, RFD]: Unbreak no-mmu mmap Bernd Schmidt
2007-06-09 19:10 ` Matt Mackall
2007-06-11 21:08   ` Robin Getz
2007-06-11 22:09   ` Mike Frysinger
2007-06-11 23:04     ` Bernd Schmidt
2007-06-11 23:22       ` Mike Frysinger
2007-06-19 23:26 ` Robin Getz
2007-06-20  2:38   ` Bryan Wu
2007-06-20  3:00 ` Paul Mundt
2007-06-20  3:18   ` Bryan Wu
2007-06-27  5:50     ` Greg Ungerer
2007-06-22 12:59 ` David Howells
2007-06-22 13:35 ` David Howells
2007-06-22 14:29 ` [PATCH] NOMMU: " David Howells
2007-08-01 12:29 ` David Howells [this message]
2007-08-03 14:03 ` [PATCH] NOMMU: Separate out VMAs David Howells
2007-08-07 13:12   ` Bernd Schmidt
2007-08-07 13:17     ` David Howells
2007-08-07 13:21       ` David Howells
2007-08-07 13:37         ` Bernd Schmidt
2007-08-07 14:03           ` David Howells
2007-08-17 11:49         ` Bernd Schmidt
2007-08-20 15:12           ` David Howells
2007-08-20 16:02             ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19618.1185971347@redhat.com \
    --to=dhowells@redhat.com \
    --cc=Bryan.Wu@analog.com \
    --cc=bernds_cb1@t-online.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox