From: David Howells <dhowells@redhat.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: dhowells@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org
Subject: checkpatch mistake on XA_STATE?
Date: Wed, 25 May 2022 11:13:07 +0100 [thread overview]
Message-ID: <1962595.1653473587@warthog.procyon.org.uk> (raw)
I see the following:
WARNING: Missing a blank line after declarations
#1921: FILE: fs/cifs/smb2ops.c:4684:
+ struct folio *folio;
+ XA_STATE(xas, buffer, 0);
but XA_STATE() technically *is* a declaration.
Should checkpatch treat it as such?
David
next reply other threads:[~2022-05-25 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:13 David Howells [this message]
2022-05-25 15:03 ` checkpatch mistake on XA_STATE? Joe Perches
2022-05-25 15:34 ` Matthew Wilcox
2022-05-25 19:03 ` [PATCH] checkpatch: Add XA_STATE and XA_STATE_ORDER to the macro declaration list Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1962595.1653473587@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox