From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B597C48BD3 for ; Wed, 26 Jun 2019 22:00:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 364AE214DA for ; Wed, 26 Jun 2019 22:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbfFZWAB (ORCPT ); Wed, 26 Jun 2019 18:00:01 -0400 Received: from gloria.sntech.de ([185.11.138.130]:56434 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfFZWAB (ORCPT ); Wed, 26 Jun 2019 18:00:01 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgFxO-0004KW-UC; Wed, 26 Jun 2019 23:59:58 +0200 From: Heiko Stuebner To: Douglas Anderson Cc: linux-rockchip@lists.infradead.org, mka@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: rockchip: Configure BT_DEV_WAKE in on rk3288-veyron Date: Wed, 26 Jun 2019 23:59:58 +0200 Message-ID: <1962605.yMxvVRIssp@phil> In-Reply-To: <20190619183425.149470-1-dianders@chromium.org> References: <20190619183425.149470-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 19. Juni 2019, 20:34:25 CEST schrieb Douglas Anderson: > This is the other half of the hacky solution from commit f497ab6b4bb8 > ("ARM: dts: rockchip: Configure BT_HOST_WAKE as wake-up signal on > veyron"). Specifically the LPM driver that the Broadcom Bluetooth > expects to have (but is missing in mainline) has two halves of the > equation: BT_HOST_WAKE and BT_DEV_WAKE. The BT_HOST_WAKE (which was > handled in the previous commit) is the one that lets the Bluetooth > wake the system up. The BT_DEV_WAKE (this patch) tells the Bluetooth > that it's OK to go into a low power mode. That means we were burning > a bit of extra power in S3 without this patch. Measurements are a bit > noisy, but it appears to be a few mA worth of difference. > > NOTE: Though these pins don't do much on systems with Marvell > Bluetooth, downstream kernels set it on all veyron boards so we'll do > the same. > > Signed-off-by: Douglas Anderson applied for 5.3 Thanks Heiko