Re: [PATCH 09/20] arm64: dts: qcom: Add PMH0101 pmic dtsi

Jishnu Prakash
2025-10-09T13:47:43Z

Hi Konrad,

On 9/25/2025 5:50 PM, Konrad Dybcio wrote:
> On 9/25/25 2:17 AM, Jingyi Wang wrote:
>> From: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>>
>> Add base DTS file for PMH0101 including temp-alarm, GPIO,
>> PWM and flash nodes.
>>
>> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/pmh0101.dtsi | 45 +++++++++++++++++++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>>

...

>> +
>> + pmh0101_flash: led-controller@ee00 {
>> + compatible = "qcom,pmh0101-flash-led", "qcom,spmi-flash-led";
>> + reg = <0xee00>;
>> + status = "disabled";
>> + };
>> +
>> + pmh0101_pwm: pwm {
>> + compatible = "qcom,pmh0101-pwm", "qcom,pm8350c-pwm";
>> + #pwm-cells = <2>;
>> + status = "disabled";
>> + };
>
> Any reason for these to be disabled?

PMH0101 is used on both Kaanapali and Glymur, but the flash and PWM
peripherals are used on Kaanapali alone and not Glymur, so we
kept them disabled by default and enabled them in the Kaanapali
board files where they would be used.

Thanks,
Jishnu

>
> Konrad