Re: [PATCH 14/20] arm64: dts: qcom: kaanapali-mtp: Enable more features

Konrad Dybcio
2025-09-26T11:44:15Z

On 9/26/25 11:11 AM, Ronak Raheja wrote:
>
> On 9/24/2025 7:09 PM, Dmitry Baryshkov wrote:
>> On Wed, Sep 24, 2025 at 05:17:31PM -0700, Jingyi Wang wrote:
>>> Enable more features on Kaanapali MTP boards including PMIC peripherals,
>>> bus, SDHCI, remoteprocs, USB, PCIE, WLAN and Bluetooth.
>>>
>>> Written with help from Jyothi Kumar Seerapu(added bus), Ronak Raheja
>>> (added USB), Manish Pandey(added SDHCI), Jishnu Prakash(added PMIC),
>>> Qiang Yu(added PCIE), Yijie Yang(Added WLAN) and Zijun Hu(Added Bluetooth).
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>> ---
>
> [...]
>
>>> +&usb_1 {
>>> + dr_mode = "peripheral";
>>
>> Is it really peripheral-only?
>>
>
> For this initial submission, we haven't yet defined the USB role detection
> infrastructure, so it didn't make sense to include dual-role now. The
> controller supports it, but without the connector bindings and role switch
> implementation, it would be non-functional.

I see an internal patch adding pmic-glink.. and I see no reason this
wasn't brought together with this version

Konrad