Re: [PATCH 18/20] arm64: dts: qcom: kaanapali-mtp: Add audio support (WSA8845, WCD9395, DMIC)

Krzysztof Kozlowski
2025-10-06T08:48:18Z

On 30/09/2025 21:06, Prasad Kumpatla wrote:
>
> On 9/25/2025 6:56 PM, Krzysztof Kozlowski wrote:
>> On Thu, 25 Sept 2025 at 09:18, Jingyi Wang <jingyi.wang@oss.qualcomm.com> wrote:
>>> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>>>
>>> Add support for audio on the Kaanapali MTP platform by introducing device
>>> tree nodes for WSA8845 smart speaker amplifier for playback, DMIC
>>> microphone for capture, and sound card routing. The WCD9395 codec is add
>>> to supply MIC-BIAS, for enabling onboard microphone capture.
>>>
>>> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 226 +++++++++++++++++++++++++++++
>>> 1 file changed, 226 insertions(+)
>>>
>> Audio is not a separate feature from USB.
>
> I didn't understand this, Could you please help me to provide more
> context on it?
> Is this regarding Audio over Type-c?

USB depends on ADSP, so your split of patches into separate audio commit
is just incorrect.

>
>> It's simply incomplete
>> picture which is wrong for case of submitting everything at once.
>> Either you release early, release often (which I asked you many
>> times), or you submit complete work.

And here I explained why.

>
> These patches enable usecase for Speaker playback and On-board-Mic
> Capture. Do you consider is there is anything need to do to make it
> complete ?

Yes, please squash patches.

Best regards,
Krzysztof