Re: [PATCH 10/20] arm64: dts: qcom: Add PMH0104 pmic dtsi

Krzysztof Kozlowski
2025-09-25T08:00:03Z

On Thu, 25 Sept 2025 at 09:17, Jingyi Wang <jingyi.wang@oss.qualcomm.com> wrote:
>
> From: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>
> Add base DTS file for PMH0104 inclduing temp-alarm and GPIO nodes.
>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pmh0104.dtsi | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmh0104.dtsi b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> new file mode 100644
> index 000000000000..f5393fdebe95
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus1 {
> + pmh0104_j_e1: pmic@PMH0104_J_E1_SID {

This might be fine for Kaanapali, but it's wrong for Glymur.

We discussed it already and I'm surprised you come with completely
different solution, not talking with the community, not aligning to
solve it properly.

Judging by other patches sent now, I recommend to drop it.

And instead just join the talks... Otherwise how am I suppose to look
at this? Everything I said should be repeated?

Best regards,
Krzysztof