Re: [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3 configuration for serial engines

Krzysztof Kozlowski
2025-09-25T13:19:56Z

On Thu, 25 Sept 2025 at 21:28, Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 9/25/25 2:17 AM, Jingyi Wang wrote:
> > From: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
> >
> > Add device tree support for QUPv3 serial engine protocols on Kaanapali.
> > Kaanapali has 24 QUP serial engines across 4 QUP wrappers, each with
> > support of GPI DMA engines, and it also includes 5 I2C hubs.
> >
> > Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
> > Co-developed-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> > Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> > ---
>
> [...]
>
> > + gpi_dma2: dma-controller@800000 {
> > + compatible = "qcom,kaanapali-gpi-dma", "qcom,sm6350-gpi-dma";
> > + reg = <0x0 0x00800000 0x0 0x60000>;
> > +
> > + interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 848 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 849 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 850 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 851 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 852 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 853 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 854 IRQ_TYPE_LEVEL_HIGH>;
>
> odd indentation (on almost all gpi_dma instances)
>
> [...]
>
> > - remoteproc_soccp: remoteproc-soccp@d00000 {
> > - compatible = "qcom,kaanapali-soccp-pas";
> > - reg = <0x0 0x00d00000 0x0 0x200000>;
> > + i2c22: i2c@1a8c000 {
> > + compatible = "qcom,geni-i2c";
> > + reg = <0x0 0x01a8c000 0x0 0x4000>;
> >
> > - interrupts-extended = <&intc GIC_SPI 167 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 9 IRQ_TYPE_EDGE_RISING>,
> > - <&soccp_smp2p_in 10 IRQ_TYPE_EDGE_RISING>;
> > - interrupt-names = "wdog",
> > - "fatal",
> > - "ready",
> > - "handover",
> > - "stop-ack",
> > - "pong",
> > - "wake-ack";
>
> Please try to use git format-patch --patience

Well, maybe it worked help, but I claim the author did not review
their work before sending. If you remove lines you added, you clearly
wrote buggy patches without any sense of proper logical split. It's
not gits fault. It's author's fault.

Best regards,
Krzysztof