From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: isdn@linux-pingi.de, linux-kernel.bfrz@manchmal.in-ulm.de,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH 3/6] isdn/hisax: add function declarations
Date: Sat, 24 Sep 2016 10:47:25 +0200 [thread overview]
Message-ID: <19682404.Wm2acsDIf0@wuerfel> (raw)
In-Reply-To: <1474694507-7379-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 1:21:47 PM CEST Baoyou Xie wrote:
> --- a/drivers/isdn/hisax/config.c
> +++ b/drivers/isdn/hisax/config.c
> @@ -460,42 +460,14 @@ __setup("hisax=", HiSax_setup);
> extern int setup_teles0(struct IsdnCard *card);
> #endif
>
> -#if CARD_TELES3
> -extern int setup_teles3(struct IsdnCard *card);
> -#endif
...
> -#if CARD_TELESPCI
> -extern int setup_telespci(struct IsdnCard *card);
> -#endif
> -
> #if CARD_AVM_A1
> extern int setup_avm_a1(struct IsdnCard *card);
> #endif
It seems odd that you remove some but not all declarations
here. Please do all of them at once.
> @@ -1350,3 +1350,63 @@ static inline struct pci_dev *hisax_find_pci_device(unsigned int vendor,
> }
>
> #endif
> +
> +#if CARD_TELES3
> +int setup_teles3(struct IsdnCard *card);
> +#endif
> +
> +#if CARD_TELESPCI
> +int setup_telespci(struct IsdnCard *card);
> +#endif
> +
When you add the declarations here, just leave out the #if guards,
and put all the declarations here unconditionally, as we normally
do in the kernel.
Arnd
next prev parent reply other threads:[~2016-09-24 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 5:21 [PATCH 3/6] isdn/hisax: add function declarations Baoyou Xie
2016-09-24 8:47 ` Arnd Bergmann [this message]
[not found] ` <CA+DQWkxE_az1C1sZ9Tjqjsgm+-E5bbdNJ_REeH6qXvPdA8JuFQ@mail.gmail.com>
2016-09-25 23:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19682404.Wm2acsDIf0@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel.bfrz@manchmal.in-ulm.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox