From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964942AbcIXIrv (ORCPT ); Sat, 24 Sep 2016 04:47:51 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:64849 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbcIXIrt (ORCPT ); Sat, 24 Sep 2016 04:47:49 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: isdn@linux-pingi.de, linux-kernel.bfrz@manchmal.in-ulm.de, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH 3/6] isdn/hisax: add function declarations Date: Sat, 24 Sep 2016 10:47:25 +0200 Message-ID: <19682404.Wm2acsDIf0@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474694507-7379-1-git-send-email-baoyou.xie@linaro.org> References: <1474694507-7379-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Axt1tM3eE8kYXWDm/q0tcmbKpd5v12LRKV55J2LJ93tvtefLQlA CggAcOkaFXGXiLGzXqWnDAOuCi7ZzBpYQdfFAOYYrgG/WSE8yPfj+Hb7ZiQGS94Qhz/nEQE 7XwdSeu6dbmomCuDsseCC6v0DhBiUADMx9ymwGGCj3yiWMlkvy0QvBXMJoKYhCmNyMTBQ7Q o16DCAFm4G5FBSG7KSw5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:M3G7yYCkm44=:KtN6IxvpDoRfPDj+2TsZjg IHalA/EHQQ8TmknFBR7Sw8Gp8T9jG27zZjx8HFlOGeMjV1e+K5PODSgRx7JMUjAfNJ4lwyB1C mLRMCYaC6CvV1+aEnTnWzC4J/INHotRmDDUhWVm6G6md+RAfF5x+RdAs8XVhxn7iZOHHcAtjt gm2ahNVVh0mLALA9kP6EnnqCkfe7XM48SSq0RIWyQMVkcWfMlQRhMySqJLyLrELR07iE9T76t 2QOXfDAiHrFVQDkQL5ufiJg+uZ8W4AZiOhmYRNCydmEbMsuUZhjp7/iyZcpqgD0TSyKY9SqC1 fJoPvvmgpW0ItaXDHVEjjqF6ddLSl+jMsLEERKsEYj+ccf/c1ekjwHhTkprVKVAvmhFUbWGax DNtLuJxrzmnz2ba6j0cvw0UjZHw+duD8f2P+vv5+dlXN0Lajj7WGXkzIxc1vu0lJjsx8+A3GA fb2SAM5Xm24Pf3V4P8qamemHMWxjEajV82Wyad5XgeSgfqCDQOKvRJBWBOLlWKWMhj33EImLD QVMSKQqUJwDAdGsn3iYRpu8g9/gPvEWcQ55x8MHHUjM7PdeoZZFjVkwvZd9FjmtRMSBXjMLrI 7gfH6ihsMDz/QpA8TejtzNueuhtlFgIjnsPezrwyXjRtNU7VDp7l1ig+f9/1t1XUX+iB52ns6 eZEzcXwzXNIhVXtLbcmu0ULSz9pJaUbNTxH4QZjRFGBvuWg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 1:21:47 PM CEST Baoyou Xie wrote: > --- a/drivers/isdn/hisax/config.c > +++ b/drivers/isdn/hisax/config.c > @@ -460,42 +460,14 @@ __setup("hisax=", HiSax_setup); > extern int setup_teles0(struct IsdnCard *card); > #endif > > -#if CARD_TELES3 > -extern int setup_teles3(struct IsdnCard *card); > -#endif ... > -#if CARD_TELESPCI > -extern int setup_telespci(struct IsdnCard *card); > -#endif > - > #if CARD_AVM_A1 > extern int setup_avm_a1(struct IsdnCard *card); > #endif It seems odd that you remove some but not all declarations here. Please do all of them at once. > @@ -1350,3 +1350,63 @@ static inline struct pci_dev *hisax_find_pci_device(unsigned int vendor, > } > > #endif > + > +#if CARD_TELES3 > +int setup_teles3(struct IsdnCard *card); > +#endif > + > +#if CARD_TELESPCI > +int setup_telespci(struct IsdnCard *card); > +#endif > + When you add the declarations here, just leave out the #if guards, and put all the declarations here unconditionally, as we normally do in the kernel. Arnd