From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932912AbbJ3UtQ (ORCPT ); Fri, 30 Oct 2015 16:49:16 -0400 Received: from mail.efficios.com ([78.47.125.74]:55981 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbbJ3UtO (ORCPT ); Fri, 30 Oct 2015 16:49:14 -0400 Date: Fri, 30 Oct 2015 20:49:04 +0000 (UTC) From: Mathieu Desnoyers To: rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Message-ID: <1968393667.16190.1446238144885.JavaMail.zimbra@efficios.com> In-Reply-To: <20151030162537.6409d174@gandalf.local.home> References: <20151029070754.584668951@goodmis.org> <20151029071031.832974028@goodmis.org> <385418149.12792.1446141136941.JavaMail.zimbra@efficios.com> <20151030162537.6409d174@gandalf.local.home> Subject: Re: [for-next][PATCH 1/5] tracepoint: Give priority to probes of tracepoints MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [78.47.125.74] X-Mailer: Zimbra 8.6.0_GA_1178 (ZimbraWebClient - FF41 (Linux)/8.6.0_GA_1178) Thread-Topic: tracepoint: Give priority to probes of tracepoints Thread-Index: kSPJ9kq2kFkNRCgnS+GrF3mT/z9q/w== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Oct 30, 2015, at 4:25 PM, rostedt rostedt@goodmis.org wrote: > On Thu, 29 Oct 2015 17:52:16 +0000 (UTC) > Mathieu Desnoyers wrote: > >> ----- On Oct 29, 2015, at 3:07 AM, rostedt rostedt@goodmis.org wrote: >> >> > From: "Steven Rostedt (Red Hat)" >> > >> > In order to guarantee that a probe will be called before other probes that >> > are attached to a tracepoint, there needs to be a mechanism to provide >> > priority of one probe over the others. >> > >> > Adding a prio field to the struct tracepoint_func, which lets the probes be >> > sorted by the priority set in the structure. If no priority is specified, >> > then a priority of 10 is given (this is a macro, and perhaps may be changed >> > in the future). >> > >> > Now probes may be added to affect other probes that are attached to a >> > tracepoint with a guaranteed order. >> > >> > One use case would be to allow tracing of tracepoints be able to filter by >> > pid. A special (higher priority probe) may be added to the sched_switch >> > tracepoint and set the necessary flags of the other tracepoints to notify >> > them if they should be traced or not. In case a tracepoint is enabled at the >> > sched_switch tracepoint too, the order of the two are not random. >> > >> > Cc: Mathieu Desnoyers >> > Signed-off-by: Steven Rostedt >> >> Sounds good to me, >> >> Acked-by: Mathieu Desnoyers >> > > Thanks. > > Unfortunately I already pushed it out to linux-next (had a deadline), > otherwise I could have added your ack. I'm guessing you missed the RFC > version I posted a week ago. No worries, I've seen it, but was busy with other stuff. Thanks, Mathieu > > -- Steve -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com