From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933887AbbLOVwK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 16:52:10 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:61552 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932469AbbLOVwG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 16:52:06 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Scott Wood <scottwood@freescale.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Paul Burton <paul.burton@imgtec.com>,
        Joachim Eastwood <manabian@gmail.com>, Mans Rullgard <mans@mansr.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Peter Hurley <peter@hurleysoftware.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v5] serial: support for 16550A serial ports on LP-8x4x
Date: Tue, 15 Dec 2015 22:51:20 +0100
Message-ID: <1970812.j9fZPC5F1b@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1450213494-21884-1-git-send-email-ynvich@gmail.com>
References: <1397668667-27328-1-git-send-email-ynvich@gmail.com> <1450213494-21884-1-git-send-email-ynvich@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:7aO2eCePxTDjWS167m7BoZTeIpMIit7s3hvYTyX0l39SQCnnJxf
 4t0FAiP8GKf8HStlOYQ3BJ9TuEvt8+sXC7bxIDk5TSYTJMZ5QxU+KG7M5i2mH70ymJuKAgD
 ewHfmo6bj2XnPkLS6vqbirShPTzr/Z7yfhTO1zL03v51UWrmaJZd3osDSjisWmoXBuHkX6I
 T3T01GnpqybrncgTgr4Sw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:/+EdO9GSQ48=:Pw7pqTili81LuW42LeOxpz
 Hswrkx3lqgoRDOu5NLl+e0lD7Kk7BazyBL5e5THTgl/Wew/jGDZeyNLMpjXJ12n94LYjquZJZ
 6exu0rI/52KpCAFzpo9vAGPEMqYvuXqFf6GFk8G8LIshL7A85Z+eV4W2V76RInO7SqFygS5S4
 mNy54Mb3OdYFdUenntsma9pzaDeZMP1zow34+0+exQf3StpcCDxOod5OAcI49yBg++FovGU/L
 dFhXQEJ7LKIuQpgKOrZ7bS4ZGEeoEcnfSTTBYSibhPPUks+BpC5sfuOrkak8S7y3ZutOOJSo3
 3CsCtcvb7sxycnsspVDpZLTjGRKj2nGTs/LJ5yLCvnMj+jAucSZQc2eKGf0jMBOFv+QMLkCE8
 zNyb12LlqNXwapN4Dzx+QgeUpMpZKsphp85f8+Rio6VS0/Qyq4TrKOU1s0CiV9McLOrT4SVhN
 zc3TmiVq8q+G/imuTVikO6RpqMmw64Rn6LDNepieTOKzhofi0IELsCMrar1c4kae6Z96Fy7XD
 jEIOyHyImXDTWp3GW19R+v4Cz/og6EVIX5AivNOxGVj+zuhQdjpzaUSOFsUymDhYBbo7Ax4QZ
 YhNCglW01EjWqPV2ODPXn3xTWpcf8xBAoYshwhCCmWT6EeseKZLc4KtxRooShblC2v6Mt4fBF
 HvV6KmlIM3R9QC3V1BXoHND5dWSIOFXSMbUy8AySJGq5Nn6OhQKVof20WkGvjZ42Lju22jqAt
 mwv4+ade5OuJp4VT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 16 December 2015 00:04:45 Sergei Ianovich wrote:
> index 0000000..5f9a4c1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/lp8x4x-serial.txt
> @@ -0,0 +1,35 @@
> +UART ports on ICP DAS LP-8x4x
> +
> +ICP DAS LP-8x4x contains three additional serial ports interfaced via
> +Analog Devices ADM213EA chips in addition to 3 serial ports on PXA CPU.
> +
> +Required properties:
> +- compatible : should be "icpdas,uart-lp8x4x"

Compatible strings should not include a 'x' wildcard like this, better use
the specific chip name.

Also, it sounds like you named them after the board vendor, which sounds
wrong as the vendor part of the compatible string should be the whoever
made that part (analog?)

> +- reg : should provide 16 byte man IO memory region and 1 byte region for
> +       termios
> +
> +- interrupts : should provide interrupt
> +
> +- interrupt-parent : should provide a link to interrupt controller either
> +                    explicitly or implicitly from a parent node

interrupt-parent should be an optional property, or you can leave it out,
as this is a standard property that can always be there when there is 
interrupts.

> +Examples (from pxa27x-lp8x4x.dts):
> +
> +               uart@9050 {

By convention, the name should be 'serial', not 'uart'.

	Arnd.