From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932577AbdIRJaZ (ORCPT ); Mon, 18 Sep 2017 05:30:25 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49122 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbdIRJaY (ORCPT ); Mon, 18 Sep 2017 05:30:24 -0400 From: Heiko Stuebner To: jeffy Cc: Rob Herring , linux-kernel@vger.kernel.org, dgreid@chromium.org, briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Mark Rutland Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Date: Mon, 18 Sep 2017 11:30:17 +0200 Message-ID: <1972340.u0BEiYTrvM@phil> User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <59BF1FCD.3060501@rock-chips.com> References: <20170906025010.10750-1-jeffy.chen@rock-chips.com> <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> <59BF1FCD.3060501@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeffy, Am Montag, 18. September 2017, 09:22:21 CEST schrieb jeffy: > On 09/14/2017 01:24 AM, Rob Herring wrote: > > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: > >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt > >> index 929ca6756b02..841a1159e234 100644 > >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt > >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt > >> @@ -4,7 +4,7 @@ This device supports I2C only. > > > > SPI support should be added to this document. > ok, will do. > > > >> > >> Required properties: > >> > >> -- compatible : "realtek,rt5514". > >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > > > There's no need for the -spi or -i2c compatibles. This is implied by > > being a child of those controllers. > heiko mentioned i should add it in the binding in: > https://patchwork.kernel.org/patch/9918987/ If you add a new compatible you need to add it to the binding. I think what Rob means is, that both the i2c and spi side can have the _same_ compatible without the -i2c or -spi, as you can check wether they are children of either a spi or i2c controller in the code itself. Heiko