From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935159AbdEVQnG (ORCPT ); Mon, 22 May 2017 12:43:06 -0400 Received: from mout.web.de ([212.227.15.14]:54790 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934585AbdEVQm6 (ORCPT ); Mon, 22 May 2017 12:42:58 -0400 Subject: [PATCH 5/5] sctp: Adjust one function call together with a variable assignment From: SF Markus Elfring To: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Neil Horman , Vlad Yasevich Cc: LKML , kernel-janitors@vger.kernel.org References: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net> Message-ID: <197333e8-b528-ef34-bd16-01e415acdf52@users.sourceforge.net> Date: Mon, 22 May 2017 18:41:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gUNiV0ak90zk06yfMoVc9/ZOGSr6Wo+ofVG4IE783CS28GmjAyu NVFIci8j0tNk73owVkoviZV2TlCtepblBxm9oMqv4CdZKZ57GaigiuEUGOQO3uBgnpDkBBk mlT/KOPmZT2+DSb4mjeYUHCgWIOgqI11l6GSmMdZHfdpvCl/qRgoGF9Xpjquoz9RC0uFSp6 i1RFWCczmLGKY8DbA42HA== X-UI-Out-Filterresults: notjunk:1;V01:K0:VLhWJDE37tA=:K43SSfy7jY6/Mrjp+d8gH5 iLCUN2Mz+P6FBkGvV7NfHjX+NGRShq33Gu3MvNQxpIqA6ZUsM3Z+eZx3jFal0zr3ApES5eX95 NJRFyVkWc8ozisWveiQ9z1o+fi3ok5IFrEKBK53wU8AT1Zca4AOnVWWvuDF9E2YyJZ44ravOS zuIWWgO6TpyX8KLiSFqd7R3DpbM6CTUUPEGm4m+NSp6L93T/nkM0lLUX60MQbGHIUlfJA0gI7 5cuTWaF2Ml+8iYmez0j0sWloVfB5P7gkcqxNqsFTINTsbxGltHf+JWaz6naXkkJyFAqVPtELT oU0k/nyQyfpbiviMYDqULC4M3CFhzXMjgDztm5ejWSE/ir1qxWxzuL1Klswl0mKGEGHqnzNBE z5vQlgUrD4PWeefxENyqRt3Ju1wP1AlufnuWkQ2uXeibCIaHfVSfK0ibvCnAFhc5QP5HPEDjM LXY21kK64GzX61BVUKSmdxF9sWOesY8tFcIqTXVOdvqktsdrUQuRYHtN1UuhqiVj51eQBlMfB 01qrBPWfKyrkomM3fVHlY5C/Pe6+mIe4nZLm8gL3pVGLA7ki1eSii9tXvGQwM50NXXH0U2jii CQt4jEsfWSB8wyr70rwSaVlRZ16EXbXYDJX53XQAyHFMXV0qSsqZe0p1koWf+EElC7s+VhbiY LDjW3XnvMiLMM+d1rGjDWvF0PPVoZRkZN3Ba54ZB4GtILZxEtvgoeqsJYqTQaAxTRvsvsNFSe w+7JZnQAQWnjlM0moebx5IsY/oSiAv50EGj0lDWCoCMHlFG0wa8She6e2VopxZ5kPVIg32Www hdbxlyI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 18:15:12 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- net/sctp/protocol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 057479b7bd72..be2fe3ebae78 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -141,7 +141,8 @@ static void sctp_v4_copy_addrlist(struct list_head *addrlist, struct sctp_sockaddr_entry *addr; rcu_read_lock(); - if ((in_dev = __in_dev_get_rcu(dev)) == NULL) { + in_dev = __in_dev_get_rcu(dev); + if (!in_dev) { rcu_read_unlock(); return; } -- 2.13.0