From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbcEBPla (ORCPT ); Mon, 2 May 2016 11:41:30 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56576 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754214AbcEBPlR (ORCPT ); Mon, 2 May 2016 11:41:17 -0400 From: Arnd Bergmann To: Christoph Hellwig Cc: linux-arm-kernel@lists.infradead.org, Yury Norov , Andre Przywara , linux-kernel@vger.kernel.org Subject: Re: [question] pread2, pwrite2 unistd symbols for compat Date: Mon, 02 May 2016 17:40:30 +0200 Message-ID: <1979597.XqcnTZ9GDk@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160502152248.GA716@lst.de> References: <20160502134706.GA11396@yury-N73SV> <9552994.HgmuyIW9Ty@wuerfel> <20160502152248.GA716@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Z3VSBiYCDyCXiskhOlg7QbeFywRDGcRDkz2/E3rPmMlUzseMhxm y/RHbIacO8fmr79I5DWlL9CMvGD9kmtjPqWSjJ5o/Qg4dnjHoMJqcrn9NZNPiu0Hl8eNKgm elstxTcxG4hQVmb65wTOALXqvPwyMsE8V4BmwN+F0ywP+XC5YE/l7nYsArVQtUagIwxNl9V WNPLfKytWhnTkvwddXoiQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:b/9gDdHw6UM=:mW+zV+cn3kbBLSdh0j547y +vMoBo1vV/+lHQLWpT+56Uu7BsppVOHTeLgMux69aS120I+Hn55jRd70od9IR1IMN5Al1xK55 lVZX214FfFFLkwfFrTq0PMeIdQsV2SYHEHmOu9rsAFkbfwbjfr8LVfoQZhhrHZugGZYChTj63 BhGVj4f9P4zEwiAu0zWrtIsinDgZ5HjGg3TtgK7oXVLZqUaQj+VgnryaWnDXXhUpLxld8zUJW ig73btexTTrGve09sG6aPEQ3k0yBHJEKzgsdiecYRik6C0SIzb++9Mm9C/y/l14TAQVCwM0Xq BDuXPqpMHYS2CVAhfPrT0QExMbAN+L6gXsHFs23/FD6b/XUhnMSAqEln3aVMJBAALuDGNs21+ bt5GP1OzcTfUxams8aCAV+X+51DqTlibolpQdQ27iSaEFGLPCyWYMU1mmDiqjK3JSmAAL4SL8 g0q8t0pX/OmKxK22L0cesMU5lwojJ+H8NJij78Mf2KAJ7576VHYE9tshSyPM0ggzocRJhZ+qj HwU7WqE1VYdkD/OTsqT2LIcI+qEIzAt+9pZMc63YKSzPJC0BhumFPGF/ym4NyP6+4KrFWy6/2 XQNF1uk1BBmJM2GglWTOvU27oR38m2aPG6/Za6MPjtR5S4UXFmRK7f/KwXYBhEUbNFh5sIhbh 7X4g1Ycc7G7etMZkv2x1ftciGO5EwZuVrH0zc+dcVprZ3s0D3e0QmjSP19/0AzoeUzFDl5anw H6CdH0OJPPkYR8D1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 May 2016 17:22:48 Christoph Hellwig wrote: > On Mon, May 02, 2016 at 05:20:22PM +0200, Arnd Bergmann wrote: > > After I got the original patch from Andre and the same one from Christoph, > > I did not consider the possibility that they were both wrong and so I > > applied Andre's version. > > It's because adding syscalls is simple a giant pain, full of pitfalls > that are completely non-obvious. When asked to add syscalls for > architectures I can't personally test I'll have to rely on the test > bot giving me some feedback - and it seems the wrong thing here will > just silently pass without any notice. > > The change looks fine to me, but then again I just demonstrated a complete > lack of clue on asm-generic syscalls.. Ok, so I didn't miss anything obvious here and will forward the patch as soon as Yury sends it. I guess this is one more reason for me to finally do the job of generalizing the system call tables to the point where we only add them in one place of the kernel. There are probably 22 new syscalls we need for 64-bit time_t, so doing it right then can also some copy-paste errors. Arnd