From: David Howells <dhowells@redhat.com>
To: Bobby Powers <bobbypowers@gmail.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable
Date: Wed, 22 Feb 2012 10:18:56 +0000 [thread overview]
Message-ID: <1986.1329905936@redhat.com> (raw)
In-Reply-To: <1329888587-3087-1-git-send-email-bobbypowers@gmail.com>
Bobby Powers <bobbypowers@gmail.com> wrote:
> alloc_fdtable allocates space for the open_fds and close_on_exec
> bitfields together, as 2 * nr / BITS_PER_BYTE. close_on_exec needs to
> point to open_fds + nr / BITS_PER_BYTE, not open_fds + nr /
> BITS_PER_LONG, as introducted in 1fd36adc: Replace the fd_sets in
> struct fdtable with an array of unsigned longs.
>
> Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
Yes, you're right. At one point I changed data to be an unsigned long *.
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2012-02-22 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 5:29 [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable Bobby Powers
2012-02-22 10:18 ` David Howells [this message]
2012-02-23 14:40 ` Bobby Powers
2012-02-23 14:56 ` H. Peter Anvin
2012-02-24 2:42 ` [tip:core/types] fs: Fix " tip-bot for Bobby Powers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1986.1329905936@redhat.com \
--to=dhowells@redhat.com \
--cc=bobbypowers@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).