From: Robert Beckett <bob.beckett@collabora.com>
To: "Antheas Kapenekakis" <lkml@antheas.dev>
Cc: amd-gfx <amd-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
philm <philm@manjaro.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"\"Christian König\"" <christian.koenig@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: Re: [PATCH v1 5/5] drm: panel-backlight-quirks: Add Steam Decks
Date: Tue, 26 Aug 2025 12:38:47 +0100 [thread overview]
Message-ID: <198e62c6b4d.895a68a41708589.706102196190635345@collabora.com> (raw)
In-Reply-To: <20250824200202.1744335-6-lkml@antheas.dev>
---- On Sun, 24 Aug 2025 21:02:02 +0100 Antheas Kapenekakis <lkml@antheas.dev> wrote ---
> On the SteamOS kernel, Valve universally makes minimum brightness 0
> for all devices. SteamOS is (was?) meant for the Steam Deck, so
> enabling it universally is reasonable. However, it causes issues in
> certain devices. Therefore, introduce it just for the Steam Deck here.
>
> SteamOS kernel does not have a public mirror, but this replaces commit
> 806dd74bb225 ("amd/drm: override backlight min value from 12 -> 0")
> in the latest, as of this writing, SteamOS kernel (6.11.11-valve24).
> See unofficial mirror reconstructed from sources below.
>
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/806dd74bb225
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
> drivers/gpu/drm/drm_panel_backlight_quirks.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> index 78c430b07d6a..5c24f4a86519 100644
> --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> @@ -73,7 +73,22 @@ static const struct drm_get_panel_backlight_quirk drm_panel_min_backlight_quirks
> .dmi_match_other.field = DMI_PRODUCT_NAME,
> .dmi_match_other.value = "ONEXPLAYER F1 EVA-02",
> .quirk = { .brightness_mask = 3, },
> - }
> + },
> + /* Steam Deck models */
> + {
> + .dmi_match.field = DMI_SYS_VENDOR,
> + .dmi_match.value = "Valve",
> + .dmi_match_other.field = DMI_PRODUCT_NAME,
> + .dmi_match_other.value = "Jupiter",
> + .quirk = { .min_brightness = 1, },
> + },
> + {
> + .dmi_match.field = DMI_SYS_VENDOR,
> + .dmi_match.value = "Valve",
> + .dmi_match_other.field = DMI_PRODUCT_NAME,
> + .dmi_match_other.value = "Galileo",
> + .quirk = { .min_brightness = 1, },
> + },
> };
>
> static bool drm_panel_min_backlight_quirk_matches(
> --
> 2.50.1
>
Reviewed-by: Robert Beckett <bob.beckett@collabora.com>
next prev parent reply other threads:[~2025-08-26 11:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 20:01 [PATCH v1 0/5] drm: panel-backlight-quirks: Do partial refactor and apply OLED fix Antheas Kapenekakis
2025-08-24 20:01 ` [PATCH v1 1/5] drm: panel-backlight-quirks: Make ident optional Antheas Kapenekakis
2025-08-24 20:01 ` [PATCH v1 2/5] drm: panel-backlight-quirks: Convert brightness quirk to generic structure Antheas Kapenekakis
2025-08-25 17:53 ` Mario Limonciello
2025-08-26 12:29 ` Philip Müller
2025-08-24 20:02 ` [PATCH v1 3/5] drm: panel-backlight-quirks: Add secondary DMI match Antheas Kapenekakis
2025-08-26 12:29 ` Philip Müller
2025-08-24 20:02 ` [PATCH v1 4/5] drm: panel-backlight-quirks: Add brightness mask quirk Antheas Kapenekakis
2025-08-25 18:02 ` Mario Limonciello
2025-08-25 21:17 ` Antheas Kapenekakis
2025-08-25 21:22 ` Mario Limonciello
2025-08-25 21:26 ` Antheas Kapenekakis
2025-08-26 12:28 ` Philip Müller
2025-08-24 20:02 ` [PATCH v1 5/5] drm: panel-backlight-quirks: Add Steam Decks Antheas Kapenekakis
2025-08-25 16:47 ` Mario Limonciello
2025-08-25 21:02 ` Antheas Kapenekakis
2025-08-25 21:05 ` Mario Limonciello
2025-08-25 21:20 ` Antheas Kapenekakis
2025-08-26 11:38 ` Robert Beckett [this message]
2025-08-25 16:45 ` [PATCH v1 0/5] drm: panel-backlight-quirks: Do partial refactor and apply OLED fix Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198e62c6b4d.895a68a41708589.706102196190635345@collabora.com \
--to=bob.beckett@collabora.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=mario.limonciello@amd.com \
--cc=philm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).