From: David Howells <dhowells@redhat.com>
To: viro@ftp.linux.org.uk, hch@infradead.org, torvalds@osdl.org
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Credentials test patch
Date: Mon, 17 Sep 2007 16:27:43 +0100 [thread overview]
Message-ID: <19966.1190042863@redhat.com> (raw)
In-Reply-To: <1577.1189713412@redhat.com>
David Howells <dhowells@redhat.com> wrote:
> (1) Permit one process to change another process's cred struct. This means
> that a process wishing to read its own creds must use RCU read to do so,
> and a lock must be held when replacing the cred struct.
Having thought about this some more, I've realised that this also doesn't work
if when one thread tries to alter another thread's creds that other thread's
cred struct is currently overridden.
> (2) Explicitly update the cred struct on entry to syscalls that might want to
> use it.
So, I think this has to be the best way to do things. It's the cleanest,
certainly and probably has the lowest overhead overall.
This also means that I don't need that horrible __current_cred() function that
Linus so objects to (I do too).
David
next prev parent reply other threads:[~2007-09-17 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 19:56 Credentials test patch David Howells
2007-09-13 20:09 ` Linus Torvalds
2007-09-13 21:19 ` David Howells
2007-09-13 21:33 ` Linus Torvalds
2007-09-15 15:51 ` Ulrich Drepper
2007-09-17 11:02 ` David Howells
2007-09-17 14:28 ` Ulrich Drepper
2007-09-17 15:27 ` David Howells [this message]
2007-09-18 16:33 ` David Howells
2007-09-18 16:44 ` Trond Myklebust
2007-09-18 17:25 ` David Howells
2007-09-18 17:58 ` Casey Schaufler
2007-09-18 18:03 ` Trond Myklebust
2007-09-18 18:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19966.1190042863@redhat.com \
--to=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox