The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Federico Vaga <federico.vaga@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Pawel Osciak <pawel@osciak.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators
Date: Fri, 21 Sep 2012 11:54:31 +0200	[thread overview]
Message-ID: <1996811.RHEzVXgiFK@harkonnen> (raw)
In-Reply-To: <201209211136.02263.hverkuil@xs4all.nl>

> > 
> > + * @prepare:	called everytime the buffer is passed from userspace
> > to the
> nitpick: everytime -> every time
> 
> > + *		driver, usefull for cache synchronisation, optional
> > + * @finish:	called everytime the buffer is passed back from the
> > driver
> ditto.
> 

This patch come from here: https://patchwork.kernel.org/patch/1323411/

I send it with my patch set because my work require this patch but it is 
not in the next tree. I think it is convenient to fix the original 
patch, probably it will be integrated in the kernel before this one; so 
this patch will be useless.

Anyway, I will apply this comment fix.

-- 
Federico Vaga

  reply	other threads:[~2012-09-21  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21  9:21 [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators Federico Vaga
2012-09-21  9:21 ` [PATCH v2 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator Federico Vaga
2012-09-21  9:21 ` [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2012-09-21  9:47   ` Hans Verkuil
2012-09-23 17:20     ` Federico Vaga
2012-09-21  9:21 ` [PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2012-09-21  9:36 ` [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators Hans Verkuil
2012-09-21  9:54   ` Federico Vaga [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-13 13:52 Federico Vaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1996811.RHEzVXgiFK@harkonnen \
    --to=federico.vaga@gmail.com \
    --cc=corbet@lwn.net \
    --cc=giancarlo.asnaghi@st.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@infradead.org \
    --cc=pawel@osciak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox