From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345AbcFQJXG (ORCPT ); Fri, 17 Jun 2016 05:23:06 -0400 Received: from mail.eperm.de ([89.247.134.16]:36712 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbcFQJXD (ORCPT ); Fri, 17 Jun 2016 05:23:03 -0400 From: Stephan Mueller To: Dan Carpenter Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel() Date: Fri, 17 Jun 2016 11:23 +0200 Message-ID: <1997601.iEDOaUsuK2@tauon.atsec.com> User-Agent: KMail/4.14.10 (Linux/4.4.9-300.fc23.x86_64; KDE/4.14.20; x86_64; ; ) In-Reply-To: <1774858.Ao0ox7E6zA@tauon.atsec.com> References: <20160617091618.GC25609@mwanda> <1774858.Ao0ox7E6zA@tauon.atsec.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 17. Juni 2016, 11:19:58 schrieb Stephan Mueller: Hi Stephan, > Am Freitag, 17. Juni 2016, 12:16:19 schrieb Dan Carpenter: > > Hi Dan, > > > We accidentally return PTR_ERR(NULL) which is success but we should > > return -ENOMEM. > > > > Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES') > > Signed-off-by: Dan Carpenter > > Acked-by: Stephan Mueller > > That points to an error in the documentation of skcipher_request_alloc. Apologies, that documentation issue has already been fixed in the cryptodev-2.6 tree. I was looking at the vanilla 4.6 tree for the documentation while I was preparing my patch. Ciao Stephan