From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbdEVJPE (ORCPT ); Mon, 22 May 2017 05:15:04 -0400 Received: from mout.web.de ([212.227.15.3]:50715 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757781AbdEVJOv (ORCPT ); Mon, 22 May 2017 05:14:51 -0400 Subject: [PATCH 2/3] net: pktgen: Delete an error message for a failed memory allocation in pktgen_create_thread() From: SF Markus Elfring To: netdev@vger.kernel.org, Alexey Dobriyan , "David S. Miller" , Eric Dumazet , Florian Westphal , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , John Fastabend , Paolo Abeni , Willem de Bruijn Cc: LKML , kernel-janitors@vger.kernel.org References: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Message-ID: <19b7151b-ce0d-54a9-c079-4d17c31c2339@users.sourceforge.net> Date: Mon, 22 May 2017 11:13:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:daykceSLu2KneL1Y3+2KhUCbeQWHM7cRFtQo12kL1gy9Aux25pg K/YTjdiic8OB9mPWn84xQbszd/10jdp2wPyDoo5lSldao9IM5gghMPKVps0YIk35U+CSwD2 +mNN5CbY4ENdZI0jsci2Fi7prPXTgmTe/KXzO1v9H2OK0ODxuYh0yTbIx6W+mKREL9wrrfX HgdeuD6a7ptPh+tKeJ3yg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Kf9329bgb5s=:6Nx80U0TySh1gn/kZkia0R 8RrYZs2Pc+jwzLOKetzBwIUETl/zb5/3EHO7JwU4siUuG2ek6icKldpn10MRaPS+1hsY6gPE5 B5HhPmpyycHlwRjiixAEJEV0HnwDwPXUDdV1ig77ydeFzBVv6AARhnDYEWXf3xDAl+clqINxa oH0MeXF+ijuaM8N+bAOivHZhbDcmmyLbVmC7/yQByAz3Sx9eG8fmHTDgi4xKzrzAM4UJE39Vs 96k/i+XUJza6R+gktpGDPolr54Ev396/eSSK4Yvg8qLmzn+VvcYpd7BsiHTZg1/Ot0cluHF+N F/wY45KxxzpJ/9kqB/FeA9N64rB2v5Tl8X2kmgXUrLY5bxkrNx8brF8F6CEB9/8xH1ZYYGXSi yGHeH/+UDBnbSZUkJMB/nJrJDkX0PWYQwJq8sljI0KoBSG3pOGJIB0b8Ej+/VLN4pPLrB4VnK uIOelgUnxE9aO2whk46vWfSyA8r+o1czquf6K31GSvmjTxaBBWjLf1epRpRsxCMYJxQM9ezy/ RleXnfUWDBVQFKGnlmWUspX5Da4yfyHPnt7cP8xbe2zCFe97vo824Vxq4xrtyBgF+5lcyyxuY bcEb1UgVHrSKTQn69gb9vErvvEvr+I0iU6zPRRAMpKjek87p+GGJeqkwcqeSX9VWrrAdy5Fpc WI19rc66TtIKApfeB8+H5Z2rkWm3HxtCTtfDjDQKWf/e1rj8d/F0tcwWQnpzyA+cfwvBRsOjW /9t+Mo6ZALzf5Tlygza2tkvGrix4SL7XP+2KHu2oC5tf3PiQktXW5FdETDuNrJm6W+D675/u9 5cGPrhB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 10:38:46 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/core/pktgen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index c89f4ad21187..51008ddc7af6 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -3760,7 +3760,5 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn) - if (!t) { - pr_err("ERROR: out of memory, can't create new thread\n"); + if (!t) return -ENOMEM; - } mutex_init(&t->if_lock); t->cpu = cpu; -- 2.13.0