From: Neil Armstrong <neil.armstrong@linaro.org>
To: ye.xingchen@zte.com.cn, glaroque@baylibre.com
Cc: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe()
Date: Fri, 24 Mar 2023 11:11:41 +0100 [thread overview]
Message-ID: <19b78f85-141e-eab7-2f4f-a30db3f8fb7e@linaro.org> (raw)
In-Reply-To: <202303241020110014476@zte.com.cn>
On 24/03/2023 03:20, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/thermal/amlogic_thermal.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 4bf36386462f..3abc2dcef408 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
> return PTR_ERR(pdata->regmap);
>
> pdata->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(pdata->clk)) {
> - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get clock\n");
> - return PTR_ERR(pdata->clk);
> - }
> + if (IS_ERR(pdata->clk))
> + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n");
>
> pdata->sec_ao_map = syscon_regmap_lookup_by_phandle
> (pdev->dev.of_node, "amlogic,ao-secure");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-03-24 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 2:20 [PATCH] thermal: amlogic: Use dev_err_probe() ye.xingchen
2023-03-24 10:11 ` Neil Armstrong [this message]
2023-03-25 13:09 ` Martin Blumenstingl
2023-04-01 20:39 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b78f85-141e-eab7-2f4f-a30db3f8fb7e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=glaroque@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox