From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
kernel-janitors@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Günter Röck" <linux@roeck-us.net>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH] eeprom: ee1004: Unlock on error path in probe()
Date: Fri, 12 Jul 2024 17:42:12 +0200 [thread overview]
Message-ID: <19bb8ed0-e783-49aa-a4cd-6a0c3b89f0a8@web.de> (raw)
In-Reply-To: <b5c51026-a2de-434b-8f45-44a641ab1c82@stanley.mountain>
> Call mutex_unlock() before returning an error in ee1004_probe()
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&ee1004_bus_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/mutex.h#L196
Would you like to refer to the function name “ee1004_probe” in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-07-12 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 14:04 [PATCH] eeprom: ee1004: Unlock on error path in probe() Dan Carpenter
2024-07-12 14:12 ` Arnd Bergmann
2024-07-12 15:42 ` Markus Elfring [this message]
2024-07-12 16:14 ` Greg Kroah-Hartman
2024-07-12 19:27 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19bb8ed0-e783-49aa-a4cd-6a0c3b89f0a8@web.de \
--to=markus.elfring@web.de \
--cc=W_Armin@gmx.de \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox