Re: [PATCH rc v8 1/8] iommu: Fix NULL group->domain dereference in pci_dev_reset_iommu_done()

Baolu Lu
2026-04-27T08:32:38Z

On 4/25/2026 9:15 AM, Nicolin Chen wrote:
> Local sashiko review pointed it out that group->domain could be NULL when
> a default domain fails to allocate during the first probe, which can crash
> at domain->ops->attach_dev dereference in __iommu_attach_device() invoked
> by pci_dev_reset_iommu_done().
>
> pci_dev_reset_iommu_prepare() is fine as an old_domain pointer can be NULL.
>
> Skip the re-attach in pci_dev_reset_iommu_done() to fix the bug.
>
> Fixes: c279e83953d9 ("iommu: Introduce pci_dev_reset_iommu_prepare/done()")
> Cc:stable@vger.kernel.org
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> drivers/iommu/iommu.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)