From: Jiri Slaby <jirislaby@kernel.org>
To: linux@treblig.org, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/ldsem: Remove unused ldsem_down_write_trylock
Date: Wed, 22 Jan 2025 07:17:15 +0100 [thread overview]
Message-ID: <19d34aba-2ded-4aa3-b76f-5120ad669720@kernel.org> (raw)
In-Reply-To: <20250122012559.441006-1-linux@treblig.org>
On 22. 01. 25, 2:25, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> ldsem_down_write_trylock() was added in 2013 by
> commit 4898e640caf0 ("tty: Add timed, writer-prioritized rw semaphore")
> but hasn't been used.
>
> Remove it.
Right, it was likely added for symmetry. However having untested+unused
code is indeed wrong.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
prev parent reply other threads:[~2025-01-22 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 1:25 [PATCH] tty/ldsem: Remove unused ldsem_down_write_trylock linux
2025-01-22 6:17 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d34aba-2ded-4aa3-b76f-5120ad669720@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox