From: Eli Billauer <eli.billauer@gmail.com>
To: Pan Chuang <panchuang@vivo.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:XILLYBUS DRIVER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] char: xillybus: Remove redundant dev_err()
Date: Sat, 11 Jul 2026 17:46:31 +0200 [thread overview]
Message-ID: <19e99783-df6e-eca5-ba79-40fd55404bf6@outbound.gmail.com> (raw)
In-Reply-To: <20260710105318.376496-4-panchuang@vivo.com>
On 10/07/2026 12:53, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
My opinion about error messages is the more the merrier, but I suppose
this is part of a more general code cleanup. As this specific error
message isn't expected to happen often, I have no reason to object.
Thanks & regards,
Eli
Acked-by: Eli Billauer <eli.billauer@gmail.com>
prev parent reply other threads:[~2026-07-11 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:53 [PATCH 0/3] char: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-10 10:53 ` [PATCH 1/3] hwrng: drivers - Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-10 10:53 ` [PATCH 2/3] tpm: Remove redundant dev_err() Pan Chuang
2026-07-11 17:37 ` Jarkko Sakkinen
2026-07-10 10:53 ` [PATCH 3/3] char: xillybus: " Pan Chuang
2026-07-11 15:46 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e99783-df6e-eca5-ba79-40fd55404bf6@outbound.gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=panchuang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox