Re: [RESEND][PATCH 1/2] stacktrace: add saved stack traces to backtrace self-test

["Vegard Nossum" <vegard.nossum@gmail.com>]

On Fri, Jun 27, 2008 at 9:20 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> FYI, it needed the fixlet below.
>
>        Ingo
>

Oh. I'm sorry :-(

(I'll admit that I've never worked with modules before. I'll try to
remember now.)

> ------------->
> commit 7bcebd2e3ee8435e2ff0f674a409f46961fda3cc
> Author: Ingo Molnar <mingo@elte.hu>
> Date:   Fri Jun 27 21:20:17 2008 +0200
>
>    stacktrace: export print_stack_trace and save_stack_trace
>
>    fix:
>
>    ERROR: "print_stack_trace" [kernel/backtracetest.ko] undefined!
>    ERROR: "save_stack_trace" [kernel/backtracetest.ko] undefined!
>
>    Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
>    Conflicts:
>
>    Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
> index c28c342..b7b483b 100644
> --- a/arch/x86/kernel/stacktrace.c
> +++ b/arch/x86/kernel/stacktrace.c
> @@ -74,10 +74,4 @@ void save_stack_trace(struct stack_trace *trace)
>        if (trace->nr_entries < trace->max_entries)
>                trace->entries[trace->nr_entries++] = ULONG_MAX;
>  }
> -
> -void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
> -{
> -       dump_trace(tsk, NULL, NULL, 0, &save_stack_ops_nosched, trace);
> -       if (trace->nr_entries < trace->max_entries)
> -               trace->entries[trace->nr_entries++] = ULONG_MAX;
> -}

Why is this removed, though? (It seems unrelated, and that's a useful function.)


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036