From: Thorsten Blum <thorsten.blum@linux.dev>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] rpmsg: Use strscpy() instead of strscpy_pad()
Date: Tue, 10 Jun 2025 12:38:14 +0200 [thread overview]
Message-ID: <1F19F750-E9CF-4AC8-B14E-78C957869F75@linux.dev> (raw)
In-Reply-To: <CANLsYkxBxt-fE-kV3yS7WDQuF4o7OSL045fMmXrTvfx3P=A+1A@mail.gmail.com>
Hi Mathieu,
On 30. Apr 2025, at 16:59, Mathieu Poirier wrote:
> On Tue, 29 Apr 2025 at 04:46, Thorsten Blum wrote:
>>
>> kzalloc() already zero-initializes the destination buffer, making
>> strscpy() sufficient for safely copying the name. The additional NUL-
>> padding performed by strscpy_pad() is unnecessary.
>>
>> The size parameter is optional, and strscpy() automatically determines
>> the size of the destination buffer using sizeof() when the argument is
>> omitted. RPMSG_NAME_SIZE is equal to sizeof(rpdev->id.name) and can be
>> removed - remove it.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> ---
>> drivers/rpmsg/qcom_glink_native.c | 2 +-
>> drivers/rpmsg/qcom_smd.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
> I will let Bjorn take care of this one.
This one didn't make it into the last merge window, did it?
Could you or Bjorn take care of it or should I resend it?
Thanks,
Thorsten
next prev parent reply other threads:[~2025-06-10 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 10:45 [RESEND PATCH] rpmsg: Use strscpy() instead of strscpy_pad() Thorsten Blum
2025-04-30 14:59 ` Mathieu Poirier
2025-06-10 10:38 ` Thorsten Blum [this message]
2025-06-11 3:07 ` Bjorn Andersson
2025-06-17 21:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F19F750-E9CF-4AC8-B14E-78C957869F75@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox