Re: [PATCH 2/3] dt-bindings: rtc: Add Mstar SSD20xD RTC devicetree bindings documentation

Krzysztof Kozlowski
2023-05-18T08:25:14Z

On 17/05/2023 16:41, Romain Perier wrote:
> This adds the documentation for the devicetree bindings of the Mstar
> SSD20xD RTC driver.
>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

A nit, subject: drop second/last, redundant "devicetree bindings
documentation". The "dt-bindings" prefix is already stating that these
are bindings. You actually repeated everything...

> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> .../bindings/rtc/mstar,ssd20xd-rtc.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
> new file mode 100644
> index 000000000000..2acd86cce69f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/mstar,ssd20xd-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mstar SSD20xD RTC
> +
> +allOf:
> + - $ref: rtc.yaml#

This goes just above properties:

> +
> +maintainers:
> + - Daniel Palmer <daniel@0x0f.com>
> + - Romain Perier <romain.perier@gmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mstar,ssd20xd-rtc

Why rtc suffix? Can it be anything else?

Missing blank line

> + reg:
> + maxItems: 1
> +
> + start-year: true

Drop

What about interrupt line?

> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false

instead
unevaluatedProperties: false

> +
> +examples:
> + - |
> + rtc@6800 {
> + compatible = "mstar,ssd20xd-rtc";
> + reg = <0x6800 0x200>;
> + };
> +...

Best regards,
Krzysztof