Re: [PATCH 2/3] dt-bindings: rtc: Add Mstar SSD20xD RTC devicetree bindings documentation

Conor Dooley
2023-05-17T17:45:40Z

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

Hey Romain,

On Wed, May 17, 2023 at 04:41:43PM +0200, Romain Perier wrote:
> This adds the documentation for the devicetree bindings of the Mstar
> SSD20xD RTC driver.

Bindings describe hardware, not the driver ;)

>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> .../bindings/rtc/mstar,ssd20xd-rtc.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
> new file mode 100644
> index 000000000000..2acd86cce69f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/mstar,ssd20xd-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mstar SSD20xD RTC
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +maintainers:
> + - Daniel Palmer <daniel@0x0f.com>
> + - Romain Perier <romain.perier@gmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mstar,ssd20xd-rtc

Is this x a wildcard?
In general, having a specific compatible is preferred, and if there are
other models that are compatible we can list several "fall back" to the
most specific one implemented in a driver.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]