public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>, Borislav Petkov <bp@alien8.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Suzuki K Poulose <Suzuki.Poulose@arm.com>,
	linux-pci@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jan Glauber <jan.glauber@caviumnetworks.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/3] perf: cavium: Support memory controller PMU counters
Date: Wed, 26 Jul 2017 13:02:38 -0700	[thread overview]
Message-ID: <1a2eedea-040d-c746-eaf0-1d8085b3f2bf@gmail.com> (raw)
In-Reply-To: <20170726173353.GB21705@kroah.com>

On 07/26/2017 10:33 AM, Greg KH wrote:
> On Wed, Jul 26, 2017 at 06:30:49PM +0200, Borislav Petkov wrote:
>> On Wed, Jul 26, 2017 at 09:19:49AM -0700, Greg KH wrote:
>>> On Wed, Jul 26, 2017 at 05:55:48PM +0200, Borislav Petkov wrote:
>>>> On Wed, Jul 26, 2017 at 05:45:15PM +0200, Jan Glauber wrote:
>>>>> The PMU/EDAC devices are all PCI devices do I need the 'struct pci_dev *'.
>>>>> I'm not aware of other ways to access these devices. Please enlighten
>>>>> me if I'm missing something.
>>>>
>>>> Me enlighten you on Cavium hardware?! You're funny.
>>>>
>>>> So I don't know whether the PCI hotplug code can run more than one
>>>> function upon PCI ID detection. Probably Greg will say, write a
>>>> multiplexer wrapper. :-)
>>>
>>> -ENOCONTEXT....
>>>
>>> Anyway, pci questions are best asked on the linux-pci@vger list.  And
>>> yes, all PCI devices end up with a 'struct pci_dev *' automatically.
>>
>> Simple: so they have a PCI ID of a memory contoller and want to hotplug
>> two drivers for it. And those two drivers should remain independent from
>> each other.
> 
> Hahahahaha, no.  That's crazy, you were right in guessing what my answer
> was going to be :)
> 


Just to be clear about the situation, the device is a memory controller. 
  It has two main behaviors we are interested in:

A) Error Detection And Correction (EDAC).  This should be connected to 
the kernel's EDAC subsystem.  An existing driver 
(drivers/edac/thunderx_edac.c) does exactly this.

B) Performance Counters for actions taken in the corresponding memory. 
This should be connected to the kernel's perf framework as an uncore-PMU 
(the subject of this patch set).

It is a single PCI device.  What should the driver architecture look 
like to connect it to two different kernel subsystems?

Thanks,
David Daney

  reply	other threads:[~2017-07-26 20:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 15:04 [PATCH v8 0/3] Cavium ARM64 uncore PMU support Jan Glauber
2017-07-25 15:04 ` [PATCH v8 1/3] perf: cavium: Support memory controller PMU counters Jan Glauber
2017-07-25 15:39   ` Suzuki K Poulose
2017-07-26 11:19     ` Jan Glauber
2017-07-26 12:47       ` Suzuki K Poulose
2017-07-26 13:10         ` Jan Glauber
2017-07-26 14:35           ` Suzuki K Poulose
2017-07-26 14:55             ` Borislav Petkov
2017-07-26 15:13               ` Jan Glauber
2017-07-26 15:17                 ` Suzuki K Poulose
2017-07-26 15:28                   ` Borislav Petkov
2017-07-26 15:46                   ` Jan Glauber
2017-07-26 16:25                     ` Jonathan Cameron
2017-07-26 16:40                       ` Jan Glauber
2017-07-26 15:35                 ` Borislav Petkov
2017-07-26 15:45                   ` Jan Glauber
2017-07-26 15:55                     ` Borislav Petkov
2017-07-26 16:19                       ` Greg KH
2017-07-26 16:30                         ` Borislav Petkov
2017-07-26 17:33                           ` Greg KH
2017-07-26 20:02                             ` David Daney [this message]
2017-07-26 20:08                               ` Greg KH
2017-07-26 21:02                                 ` David Daney
2017-07-27  2:29                                   ` Greg KH
2017-07-27 17:29                                     ` David Daney
2017-07-28  1:11                                       ` Greg KH
2017-07-28  7:23                                         ` Borislav Petkov
2017-07-27  5:11                                   ` Borislav Petkov
2017-07-27  9:08                                     ` Jan Glauber
2017-07-27 13:15                                       ` Borislav Petkov
2017-07-28 23:12                                         ` Greg KH
2017-08-08 13:25                                           ` Will Deacon
2017-08-15  9:13                                             ` Jan Glauber
2017-08-07  9:37                                       ` Suzuki K Poulose
2017-07-25 15:56   ` Jonathan Cameron
2017-07-25 15:04 ` [PATCH v8 2/3] perf: cavium: Support transmit-link " Jan Glauber
2017-07-25 15:04 ` [PATCH v8 3/3] perf: cavium: Add Documentation Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a2eedea-040d-c746-eaf0-1d8085b3f2bf@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=Suzuki.Poulose@arm.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.glauber@caviumnetworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox