From: John Clark <inindev@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jonas Karlman <jonas@kwiboo.se>,
heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
detlev.casanova@collabora.com, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support
Date: Mon, 5 May 2025 06:36:16 -0400 [thread overview]
Message-ID: <1a403393-e317-4a1b-a151-fa668c6278f9@gmail.com> (raw)
In-Reply-To: <13407dae-4c73-48a9-846e-92f08449bc4d@lunn.ch>
On 5/4/25 8:45 PM, Andrew Lunn wrote:
>>> What PHY is it? Are you using the correct PHY driver for it, or
>>> genphy?
>>>
>> MAE0621A-Q3C
>> http://www.maxio-tech.com/product/12928/12929/12930/12931.html
>
> Mainline does not have a PHY driver for this. So nothing is
> controlling the delays in the PHY. So what you have above works by
> luck, and is likely to break once there is a PHY driver. So i suggest
> you drop the Ethernet nodes for the moment.
>
> There does appear to be a PHY driver here:
>
> https://github.com/CoreELEC/linux-amlogic/blob/5.15.153_202501/drivers/net/phy/maxio.c
>
> but it has a number of things wrong with it. You might want to search
> around and see if there are any cleaner versions around, or if anybody
> is working on upstreaming a driver for this PHY.
>
> Andrew
>
Hi Andrew,
Thank you for your valuable feedback and for pointing me toward
investigating the PHY configuration further. After digging deeper into
the MAE0621A-Q3C PHY (PHY ID 0x7b744412), I now understand why it
performs reliably: the generic PHY driver relies on the GMAC to set
RGMII delays (tx_delay=0x20, rx_delay=0x10), enabling a stable 1Gbps
link for gmac0 in rgmii-rxid mode, while rgmii-id failed in my tests due
to the driver’s lack of internal delay configuration. Given the critical
role of networking for development, I’d like to retain the GMAC nodes in
v3 using this setup, but I’d greatly appreciate your approval on whether
the generic PHY driver is suitable in rgmii-rxid mode for now. I’m eager
to explore a Maxio-specific driver for mainline compatibility and would
be grateful for any guidance on existing upstreaming efforts for this PHY.
Best regards,
John
next prev parent reply other threads:[~2025-05-05 10:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 20:55 [PATCH v1 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
2025-05-02 20:55 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
2025-05-02 20:55 ` [PATCH v1 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 board John Clark
2025-05-02 20:55 ` [PATCH v1 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Carrier Board with Core3576 Module John Clark
2025-05-02 21:51 ` Andrew Lunn
2025-05-03 23:39 ` [PATCH v1 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Nicolas Frattaroli
2025-05-04 8:08 ` Heiko Stübner
2025-05-04 10:24 ` [PATCH v2 " John Clark
2025-05-04 10:24 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
2025-05-04 17:53 ` Krzysztof Kozlowski
2025-05-04 10:24 ` [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 board John Clark
2025-05-04 17:54 ` Krzysztof Kozlowski
2025-05-04 10:24 ` [PATCH v2 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support John Clark
2025-05-04 13:26 ` Jonas Karlman
2025-05-04 14:12 ` Andrew Lunn
2025-05-04 21:02 ` John Clark
2025-05-04 23:01 ` Andrew Lunn
2025-05-04 23:06 ` John Clark
2025-05-04 23:41 ` John Clark
2025-05-05 0:45 ` Andrew Lunn
2025-05-05 0:52 ` John Clark
2025-05-05 13:22 ` Diederik de Haas
2025-05-05 14:01 ` Andrew Lunn
2025-05-05 10:36 ` John Clark [this message]
2025-05-05 12:38 ` Andrew Lunn
2025-05-05 12:14 ` Jonas Karlman
2025-05-05 14:44 ` [PATCH v2 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a403393-e317-4a1b-a151-fa668c6278f9@gmail.com \
--to=inindev@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox