From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Matteo Croce <mcroce@redhat.com>
Subject: Re: [PATCH v5] checkpatch: add support to check 'Fixes:' tag format
Date: Sun, 3 May 2020 16:54:45 +0200 [thread overview]
Message-ID: <1abe0267-7c2a-53a1-bda2-469ef681d469@web.de> (raw)
In-Reply-To: <20200503143700.GA12276@udknight>
>>> + "Please use git commit description style '$prefix <$sha1_length_min+ chars of sha1> (\"<$title>\")' - ie: '${init_char}" . substr($prefix, 1) .
>>> + " $id (\"$description\")'\n" . $diagnostics . $herecurr);
>>
>> Can error diagnostics become multi-line?
> The length of "$description" is unknown, it is difficult to
> cook the error message into pretty format with any length of
> "$description", so let's keep it in current way.
How do you think about a message variant like the following?
+ "Please use git commit description style:\n$prefix <$sha1_length_min+ chars of sha1> (\"<$title>\")\n" . substr($prefix, 1)
+ . "i. e.: '${init_char} $id (\"$description\")\n"
+ . $diagnostics . $herecurr);
Regards,
Markus
prev parent reply other threads:[~2020-05-03 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 12:29 [PATCH v5] checkpatch: add support to check 'Fixes:' tag format Wang YanQing
2020-05-03 13:51 ` Markus Elfring
2020-05-03 14:37 ` Wang YanQing
2020-05-03 14:54 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1abe0267-7c2a-53a1-bda2-469ef681d469@web.de \
--to=markus.elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox