Re: [PATCH 3/5] arm64: dts: mt7622: add a property "mediatek,num-pwms" for PWM

Uwe Kleine-König
2019-01-17T19:41:18Z

Hello,

On Thu, Jan 17, 2019 at 02:00:43PM +0100, Matthias Brugger wrote:
> On 15/01/2019 21:02, Uwe Kleine-König wrote:
> > On Mon, Jan 14, 2019 at 04:21:22PM +0800, Ryder Lee wrote:
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> >> index 8fc4aa7..ab016cf 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> >> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> >> @@ -436,6 +436,7 @@
> >> <&pericfg CLK_PERI_PWM6_PD>;
> >> clock-names = "top", "main", "pwm1", "pwm2", "pwm3", "pwm4",
> >> "pwm5", "pwm6";
> >> + mediatek,num-pwms = <6>;
> >> status = "disabled";
> >
> > Conceptually this patch must go in before the change to the driver.
> > Otherwise the pwms are not usable with only patch 1 applied which breaks
> > bisectability.
> >
>
> The driver should have backwards compatibility to older DTs. So that would need
> to be fixed in the driver not in the patch order of the series.

Right you are. Bisectability is a reason to not apply the patches in the
order as is, but given that you already requested backwards
compatibility the bisectability will be fixed en passant.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |