Re: [PATCH 3/5] arm64: dts: mt7622: add a property "mediatek,num-pwms" for PWM

Matthias Brugger
2019-01-17T13:00:51Z

On 15/01/2019 21:02, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jan 14, 2019 at 04:21:22PM +0800, Ryder Lee wrote:
>> This adds a property "mediatek,num-pwms" for PWM controller.
>>
>> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> index 8fc4aa7..ab016cf 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> @@ -436,6 +436,7 @@
>> <&pericfg CLK_PERI_PWM6_PD>;
>> clock-names = "top", "main", "pwm1", "pwm2", "pwm3", "pwm4",
>> "pwm5", "pwm6";
>> + mediatek,num-pwms = <6>;
>> status = "disabled";
>
> Conceptually this patch must go in before the change to the driver.
> Otherwise the pwms are not usable with only patch 1 applied which breaks
> bisectability.
>

The driver should have backwards compatibility to older DTs. So that would need
to be fixed in the driver not in the patch order of the series.

Regards,
Matthias