From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77BB1C433E0 for ; Tue, 12 Jan 2021 18:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BFFD2311B for ; Tue, 12 Jan 2021 18:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406123AbhALScV (ORCPT ); Tue, 12 Jan 2021 13:32:21 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:62363 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391612AbhALScU (ORCPT ); Tue, 12 Jan 2021 13:32:20 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610476314; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=TUzx4xA1ScWYvWi9Xn7goti+UFU5enmnZ4wQmA91pBw=; b=D+fPG3HqmOxTcDBebUEm2igr4q4HsGToknW8KonVaXeU4x11RZHCrLZ4EHW6Uhv7RcdPUchb Fu1Ll/OlMiB1V1DOqvEGu1GosSLjoob5pYpMaa2yXwGB++umE5mzycDdE5MnxZpo8ncF+fI+ y5ZRQWgjhcX21tc1QzpWOFf9eO0= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 5ffdeb008fb3cda82f9f79b7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 Jan 2021 18:31:28 GMT Sender: sidgup=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B21B8C433CA; Tue, 12 Jan 2021 18:31:27 +0000 (UTC) Received: from [192.168.1.10] (cpe-75-83-25-192.socal.res.rr.com [75.83.25.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sidgup) by smtp.codeaurora.org (Postfix) with ESMTPSA id E80B9C433ED; Tue, 12 Jan 2021 18:31:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E80B9C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=sidgup@codeaurora.org Subject: Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile To: Greg KH Cc: mcgrof@kernel.org, rafael@kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , "psodagud@codeaurora.org" References: <7e6f44b1-a0d2-d1d1-9c11-dcea163f8f03@codeaurora.org> <180bdfaf-8c84-6946-b46f-3729d4eb17cc@codeaurora.org> <62583aaa-d557-8c9a-5959-52c9efad1fe3@codeaurora.org> From: Siddharth Gupta Message-ID: <1adf9aa4-ed7e-8f05-a354-57419d61ec18@codeaurora.org> Date: Tue, 12 Jan 2021 10:31:26 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/8/2021 6:44 AM, Greg KH wrote: > On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: >> On 1/6/2021 2:33 AM, Greg KH wrote: >>>>>> Since the binary attributes don't support splice_{read,write} functions the >>>>>> calls to splice_{read,write} used the default kernel_{read,write} functions. >>>>>> With the above change this results in an -EINVAL return from >>>>>> do_splice_from[4]. >>>>>> >>>>>> This essentially means that sendfile will not work for any binary attribute >>>>>> in the sysfs. >>>>> Have you tried fixing this with a patch much like what we did for the >>>>> proc files that needed this? If not, can you? >>>> I am not aware of this fix, could you provide me a link for reference? I >>>> will try it out. >>> Look at the series of commits starting at fe33850ff798 ("proc: wire up >>> generic_file_splice_read for iter ops") for how this was fixed in procfs >>> as an example of what also needs to be done for binary sysfs files. >> I tried to follow these fixes, but I am unfamiliar with fs code. I don't see >> the generic_file_splice_write function anymore on newer kernels, also AFAICT >> kernfs_ops does not define {read,write}_iter operations. If the solution is >> simple and someone could provide the patches I would be happy to test them >> out. If not, some more information about how to proceed would be nice. > Can you try this tiny patch out below? Sorry for the delay, I tried out the patch, but I am still seeing the error. Please take a look at these logs with android running in the userspace[1]: [   62.295056][  T249] remoteproc remoteproc1: powering up xxxxxxxx.remoteproc-cdsp [   62.304138][  T249] remoteproc remoteproc1: Direct firmware load for cdsp.mdt failed with error -2 [   62.312976][  T249] remoteproc remoteproc1: Falling back to sysfs fallback for: cdsp.mdt [   62.469748][  T394] ueventd: firmware: loading 'cdsp.mdt' for '/devices/platform/soc/xxxxxxxx.remoteproc-cdsp/remoteproc/remoteproc1/cdsp.mdt' [   62.498700][  T394] ueventd: firmware: sendfile failed { '/sys/devices/platform/soc/xxxxxxxx.remoteproc-cdsp/remoteproc/remoteproc1/cdsp.mdt', 'cdsp.mdt' }: Invalid argument Thanks, Sid [1]: https://android.googlesource.com/platform/system/core/+/refs/heads/master/init/firmware_handler.cpp#57 > > thanks, > > greg k-h > > diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c > index f277d023ebcd..113bc816d430 100644 > --- a/fs/kernfs/file.c > +++ b/fs/kernfs/file.c > @@ -968,6 +968,8 @@ const struct file_operations kernfs_file_fops = { > .release = kernfs_fop_release, > .poll = kernfs_fop_poll, > .fsync = noop_fsync, > + .splice_read = generic_file_splice_read, > + .splice_write = iter_file_splice_write, > }; > > /**