From: David Lechner <david@lechnology.com>
To: Cathy Xu <ot_cathy.xu@mediatek.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Yong Mao <yong.mao@mediatek.com>,
Wenbin Mei <Wenbin.Mei@mediatek.com>,
Axe Yang <Axe.Yang@mediatek.com>, Lei Xue <Lei.Xue@mediatek.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8189: Add pinmux macro header file
Date: Mon, 9 Feb 2026 15:48:45 -0600 [thread overview]
Message-ID: <1b092f9c-d0b1-47df-a83e-a99d7491a32b@lechnology.com> (raw)
In-Reply-To: <20250919020525.7904-1-ot_cathy.xu@mediatek.com>
On 9/18/25 9:03 PM, Cathy Xu wrote:
> Add the pinctrl header file on MediaTek mt8189.
>
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> ---
> This patch is base on the patch series:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=981475
> [1] dt-bindings: pinctrl: mediatek: Add support for mt8189
> [2] arm64: dts: mediatek: mt8189: Add pinmux macro header file
> [3] pinctrl: mediatek: Add pinctrl driver on mt8189
> Since patch [1] and [3] of the series have already been merged, this
> patch(patch [2]) is being resent individually after modifications.
> ---
> arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h | 1125 +++++++++++++++++
> 1 file changed, 1125 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
> new file mode 100644
> index 000000000000..df69f50c267a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8189-pinfunc.h
General question:
Why do we have similar files in two different places different places?
$ ls arch/arm64/boot/dts/mediatek/*-pin*
arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h
arch/arm64/boot/dts/mediatek/mt6878-pinfunc.h
arch/arm64/boot/dts/mediatek/mt6893-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8173-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8196-pinfunc.h
arch/arm64/boot/dts/mediatek/mt8516-pinfunc.h
$ ls include/dt-bindings/pinctrl/mt*
include/dt-bindings/pinctrl/mt65xx.h
include/dt-bindings/pinctrl/mt6779-pinfunc.h
include/dt-bindings/pinctrl/mt6795-pinfunc.h
include/dt-bindings/pinctrl/mt6797-pinfunc.h
include/dt-bindings/pinctrl/mt7623-pinfunc.h
include/dt-bindings/pinctrl/mt8135-pinfunc.h
include/dt-bindings/pinctrl/mt8183-pinfunc.h
include/dt-bindings/pinctrl/mt8186-pinfunc.h
include/dt-bindings/pinctrl/mt8192-pinfunc.h
include/dt-bindings/pinctrl/mt8195-pinfunc.h
include/dt-bindings/pinctrl/mt8365-pinfunc.h
Plus one different naming pattern.
$ ls include/dt-bindings/pinctrl/mediatek,*
include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h
Which one is preferred?
next prev parent reply other threads:[~2026-02-09 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 2:03 [PATCH] arm64: dts: mediatek: mt8189: Add pinmux macro header file Cathy Xu
2026-02-09 21:48 ` David Lechner [this message]
2026-02-10 11:03 ` AngeloGioacchino Del Regno
2026-02-10 12:48 ` Chen-Yu Tsai
2026-02-10 14:26 ` AngeloGioacchino Del Regno
2026-02-10 16:21 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b092f9c-d0b1-47df-a83e-a99d7491a32b@lechnology.com \
--to=david@lechnology.com \
--cc=Axe.Yang@mediatek.com \
--cc=Lei.Xue@mediatek.com \
--cc=Wenbin.Mei@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_cathy.xu@mediatek.com \
--cc=robh@kernel.org \
--cc=yong.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox