Re: [PATCH v7 12/49] x86/resctrl: Move rdt_find_domain() to be visible to arch and fs code

James Morse
2025-03-07T19:35:39Z

Hi Reinette,

On 07/03/2025 04:34, Reinette Chatre wrote:
> On 2/28/25 11:58 AM, James Morse wrote:
>> rdt_find_domain() finds a domain given a resource and a cache-id.
>> This is used by both the architecture code and the filesystem code.
>>
>> After the filesystem code moves to live in /fs/, this helper is either
>> duplicated by all architectures, or needs exposing by the filesystem code.
>>
>> Add the definition to the global header file. As its now globally visible,
>
> "definition" -> "declaration"?

Ugh, I always get those the wrong way round.

>> and has only a handful of callers, swap the 'rdt' for 'resctrl'. Move
>> the function to live with its caller in ctrlmondata.c as the filesystem
>> code will not have anything corresponding to core.c.

> | Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thanks!

James