Re: [PATCH v7 46/49] x86,fs/resctrl: Remove duplicated trace header files

James Morse
2025-03-14T17:42:27Z

Hi Fenghua,

On 07/03/2025 02:32, Fenghua Yu wrote:
> On 2/28/25 11:59, James Morse wrote:
>> The copy-pasting python script harmlessly creates some empty trace
>> point header files. Remove them.

>> diff --git a/fs/resctrl/pseudo_lock_trace.h b/fs/resctrl/pseudo_lock_trace.h
>> deleted file mode 100644
>> index 7a6a1983953a..000000000000
>> --- a/fs/resctrl/pseudo_lock_trace.h
>> +++ /dev/null
>> @@ -1,17 +0,0 @@
>> -/* SPDX-License-Identifier: GPL-2.0 */
>> -#undef TRACE_SYSTEM
>> -#define TRACE_SYSTEM resctrl
>> -
>> -#if !defined(_X86_RESCTRL_PSEUDO_LOCK_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
>> -#define _X86_RESCTRL_PSEUDO_LOCK_TRACE_H
>> -
>> -#include <linux/tracepoint.h>
>> -
>> -#endif /* _X86_RESCTRL_PSEUDO_LOCK_TRACE_H */
>> -
>> -#undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH .
>> -
>> -#define TRACE_INCLUDE_FILE pseudo_lock_trace
>> -
>> -#include <trace/define_trace.h>
>
> This patch may be merged into patch #45 to fix the compilation errors in patch #45?

As a final step before merging it. Otherwise patch 45 is impossible to work with - it
can't be reviewed, but it can be regenerated. (and the script that does that inspected to
show I have nothing up my sleeve!).

The alternative is a patch that is "mostly generated, but then lightly messed with", which
means we would want someone to double check it.

Thanks,

James