Re: [PATCH v7 48/49] fs/resctrl: Change internal.h's header guard macros

Fenghua Yu
2025-03-07T02:44:21Z

Hi, James,

On 2/28/25 11:59, James Morse wrote:
> The code in internal.h was moved by a script. The script didn't know to
> change the header guard macros. Do that.

As for "The script ...", people may forget or don't know the context of
the script in the future.

Is it better to merge this patch into patch #45 to avoid future confusion?

> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> Changes since v6:
> * This patch is new.
> ---
> fs/resctrl/internal.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h
> index f1763a13715f..ec3863d18f68 100644
> --- a/fs/resctrl/internal.h
> +++ b/fs/resctrl/internal.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _ASM_X86_RESCTRL_INTERNAL_H
> -#define _ASM_X86_RESCTRL_INTERNAL_H
> +#ifndef _FS_RESCTRL_INTERNAL_H
> +#define _FS_RESCTRL_INTERNAL_H
>
> #include <linux/resctrl.h>
> #include <linux/sched.h>
> @@ -432,4 +432,4 @@ static inline int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
> static inline void rdtgroup_pseudo_lock_remove(struct rdtgroup *rdtgrp) { }
> #endif /* CONFIG_RESCTRL_FS_PSEUDO_LOCK */
>
> -#endif /* _ASM_X86_RESCTRL_INTERNAL_H */
> +#endif /* _FS_RESCTRL_INTERNAL_H */

Thanks.

-Fenghua