Re: [PATCH v7 19/49] x86/resctrl: Add resctrl_arch_is_evt_configurable() to abstract BMEC

James Morse
2025-03-10T12:26:54Z

Hi Reinette,

On 07/03/2025 04:37, Reinette Chatre wrote:
> On 2/28/25 11:58 AM, James Morse wrote:
>> When BMEC is supported the resctrl event can be configured in a number
>> of ways. This depends on architecture support. rdt_get_mon_l3_config()
>> modifies the struct mon_evt and calls mbm_config_rftype_init() to create
>> the files that allow the configuration.
>>
>> Splitting this into separate architecture and filesystem parts would
>> require the struct mon_evt and mbm_config_rftype_init() to be exposed.
>
> Same comment as for v6 [1]:
> "Please replace all instances of mbm_config_rftype_init() with
> resctrl_file_fflags_init()."

Ah - I didn't spot there was more than on in the commit message.
(and git-grep didn't bring it back either!)

Fixed.

>> Instead, add resctrl_arch_is_evt_configurable(), and use this from
>> resctrl_mon_resource_init() to initialise struct mon_evt and call
>> resctrl_file_fflags_init()
>> resctrl_arch_is_evt_configurable() calls rdt_cpu_has() so it doesn't
>> obviously benefit from being inlined. Putting it in core.c will allow
>> rdt_cpu_has() to eventually become static.
>>
>> Signed-off-by: James Morse <james.morse@arm.com>
>> Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64
>> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> ---
>> Changes since v6:
>> * Fixed stale function name in the commit message.
> Fixes seem to have been lost.
>
> With changelog fixed:
> | Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thanks!

James