Re: [PATCH v7 40/49] fs/resctrl: Add boiler plate for external resctrl code

James Morse
2025-03-14T12:01:20Z

Hi Fenghua,

On 07/03/2025 02:16, Fenghua Yu wrote:
> On 2/28/25 11:59, James Morse wrote:
>> Add Makefile and Kconfig for fs/resctrl. Add ARCH_HAS_CPU_RESCTRL
>> for the common parts of the resctrl interface and make X86_CPU_RESCTRL
>> select this.
>>
>> Adding an include of asm/resctrl.h to linux/resctrl.h allows the
>> /fs/resctrl files to switch over to using this header instead.

>> diff --git a/fs/resctrl/pseudo_lock_trace.h b/fs/resctrl/pseudo_lock_trace.h
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>
> If merge patch 45 and 46 together to fix the pseudo_lock_trace.h compilation fatal issue,
> it's unnecessary to create pseudo_lock_trace.h here (and then the empty
> pseudo_lock_trace.h file will be deleted later in merged patch 45).

Sure, I 'll try and remember to note that on the cover letter for whoever choses to squash
those patches together.

[..]

> Other than that,
>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks,

James