From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D239C1DA21; Fri, 18 Apr 2025 04:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744952279; cv=none; b=Hk1wTV1vy0x35/8r51TIqOBM3FCtmFqA/prRYg1MmwDhZkDUAh9wqrISSH5oW633YG/4tvLk1tJu4XogpRmNFI2D5C/p+uNZP+S8Kw77ORHGCrMQZS5YMKOGf9MqwV99hRB5l4vvTGkhMPgUQ/sNHen51OYmo9X4Op1qUyX8Yik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744952279; c=relaxed/simple; bh=Q61wTq6fwgjLh5awYrNAIdvOCp25B2Jr/uabG+oMO64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SVNzhP/omuK2r5Ug/9DIn3re9/xjdn/qtqShR0dbisaWb09lgK5Y7jKsUlfIVlBNwY49lm7cIH44EPFex2cHV+24RrgaRPCzUmjQESyKATnEYtH8l2S0GfaKbCg91mQmP1fh+XSmBYqx3qKQbwvzzSEzJamSMLKbDgDw72n2ezQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KjGLgKK8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KjGLgKK8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F0EFC4CEE2; Fri, 18 Apr 2025 04:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744952278; bh=Q61wTq6fwgjLh5awYrNAIdvOCp25B2Jr/uabG+oMO64=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KjGLgKK8d6sZljrbs5FdZqujTm44FkLncXnR9NFJCG3TYFhabcUbdtqkT93e7sZq0 F+WR2G+++bElk0F1wfM/xw0iYpFvAG2TCeZUQGht8QajqCzLFzCGJcBTfIX3To32C5 rGCmhtwn0dUeJk7O6jYYFwpo0g+iBUJMpKWRU5PBjsmLx/RtzB/EkqtSacSuA3zGql xHTZ6DZ1cQHfGiDv1xTGx58yTSWh2uFYrjqzwRND6PmBeL4jMHwSzzfrSArTUAOfp9 HgzErg1EghwnTqsNUYngCPp/mObvlunaAUX1y1JZbXt7mbDfytC5UqC/gmi9aJ3Pj5 uBaVCQYQkBWcg== Message-ID: <1b17ce33-015f-4a10-9a98-ebea586c3ce4@kernel.org> Date: Thu, 17 Apr 2025 21:57:56 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] udp: Add tracepoint for udp_sendmsg() Content-Language: en-US To: Breno Leitao Cc: Willem de Bruijn , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , kuniyu@amazon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, yonghong.song@linux.dev, song@kernel.org, kernel-team@meta.com References: <20250416-udp_sendmsg-v1-1-1a886b8733c2@debian.org> <4dd9504c-4bce-4acd-874c-8eed8c311a2f@kernel.org> <8dc4d1a8-184b-4d0d-9b38-d5b65ce7e2a6@kernel.org> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/17/25 10:00 AM, Breno Leitao wrote: >> $ git grep trace_ net drivers/net | grep _tp >> net/bpf/test_run.c: trace_bpf_trigger_tp(nonce); >> net/ipv4/tcp_input.c: trace_tcp_cwnd_reduction_tp(sk, >> newly_acked_sacked, newly_lost, flag); > > Do we want to rename them and remove the _tp? I suppose it is OK given > that tracepoints are not expected to be stable? > > Also, if we have consensus about this patch, I will remove the _tp from > it. > I am only asking for consistency. Based on existing networking instances, consistency is no _tp suffix.