From: Markus Elfring <Markus.Elfring@web.de>
To: Li zeming <zeming@nfschina.com>, Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: core: Remove unnecessary ‘NULL’ values from core_rq
Date: Tue, 28 May 2024 10:03:53 +0200 [thread overview]
Message-ID: <1b4714f8-eb5c-40c6-aa3f-eb6eb7be209e@web.de> (raw)
In-Reply-To: <20240528071446.59197-1-zeming@nfschina.com>
> core_rq is assigned first, so it does not need to initialize the
> assignment.
* Would a wording approach (like the following) be a bit nicer?
The variable “core_rq” will eventually be set to an appropriate pointer
a bit later. Thus omit the explicit initialisation at the beginning.
* How do you think about to use the summary phrase
“Delete an unnecessary initialisation in sched_core_cpu_deactivate()”?
Regards,
Markus
next prev parent reply other threads:[~2024-05-28 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 7:14 [PATCH] sched: core: Remove unnecessary ‘NULL’ values from core_rq Li zeming
2024-05-28 8:03 ` Markus Elfring [this message]
2024-05-28 10:49 ` kernel test robot
2024-05-28 14:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4714f8-eb5c-40c6-aa3f-eb6eb7be209e@web.de \
--to=markus.elfring@web.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox