From: Lu Baolu <baolu.lu@linux.intel.com>
To: John Garry <john.garry@huawei.com>,
joro@8bytes.org, will@kernel.org, dwmw2@infradead.org,
robin.murphy@arm.com
Cc: baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, linuxarm@huawei.com,
thunder.leizhen@huawei.com, chenxiang66@hisilicon.com
Subject: Re: [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict()
Date: Sat, 12 Jun 2021 10:23:54 +0800 [thread overview]
Message-ID: <1b58516d-73d5-0c40-11de-58b998ec803e@linux.intel.com> (raw)
In-Reply-To: <1623414043-40745-6-git-send-email-john.garry@huawei.com>
On 2021/6/11 20:20, John Garry wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index ccbd5d4c1a50..146cb71c7441 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -350,10 +350,9 @@ static int __init iommu_dma_setup(char *str)
> }
> early_param("iommu.strict", iommu_dma_setup);
>
> -void iommu_set_dma_strict(bool strict)
> +void iommu_set_dma_strict(void)
> {
> - if (strict || !(iommu_cmd_line & IOMMU_CMD_LINE_STRICT))
> - iommu_dma_strict = strict;
> + iommu_dma_strict = true;
> }
Will this change break the functionality of iommu.strict?
Best regards,
baolu
next prev parent reply other threads:[~2021-06-12 2:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 12:20 [PATCH v12 0/5] Enhance IOMMU default DMA mode build options John Garry
2021-06-11 12:20 ` [PATCH v12 1/5] iommu: Print strict or lazy mode at init time John Garry
2021-06-14 15:54 ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 2/5] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-12 1:21 ` Lu Baolu
2021-06-14 8:11 ` John Garry
2021-06-12 2:12 ` Lu Baolu
2021-06-14 16:03 ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 3/5] iommu/vt-d: Add support for " John Garry
2021-06-12 2:14 ` Lu Baolu
2021-06-14 8:03 ` John Garry
2021-06-15 7:26 ` Lu Baolu
2021-06-15 8:25 ` Robin Murphy
2021-06-16 8:42 ` Lu Baolu
2021-06-12 2:22 ` Lu Baolu
2021-06-14 7:53 ` John Garry
2021-06-14 14:11 ` Robin Murphy
2021-06-14 14:19 ` John Garry
2021-06-14 15:05 ` Robin Murphy
2021-06-11 12:20 ` [PATCH v12 4/5] iommu/amd: " John Garry
2021-06-11 12:20 ` [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() John Garry
2021-06-12 2:23 ` Lu Baolu [this message]
2021-06-14 7:46 ` John Garry
2021-06-14 16:25 ` Robin Murphy
2021-06-14 17:03 ` John Garry
2021-06-14 17:19 ` Robin Murphy
2021-06-14 17:24 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b58516d-73d5-0c40-11de-58b998ec803e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox