Re: [PATCH v2] PL330: Add PL330 DMA controller driver

[jassi brar <jassisinghbrar@gmail.com>]

On Fri, Mar 26, 2010 at 9:29 AM, Kyungmin Park
<kyungmin.park@samsung.com> wrote:
> On Fri, Mar 26, 2010 at 8:59 AM, jassi brar <jassisinghbrar@gmail.com> wrote:
>> On Fri, Mar 26, 2010 at 8:12 AM, Dan Williams <dan.j.williams@intel.com> wrote:
>>> On Thu, Mar 25, 2010 at 3:27 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
>>>> On Fri, Mar 26, 2010 at 12:13 AM, Dan Williams <dan.j.williams@intel.com> wrote:
>>>>> It sounds like you just need to add an extension for the arch specific dma
>>>>> api.
>>>> I actually plan more than that.
>>>> Apart from inefficient design, JoonYoung's driver has made some fatal
>>>> assumptions
>>>> about PL330, which will result in DMA aborts if used with SoCs that implement
>>>> configuration of PL330 that is very different from Samsung SoCs'
> Exactly what? We are already tested it our board and play the music well.
> What's condition DMA aborts are happen?
I didn't want to get into gory details, but it seems I need to explain .....

Please see my quick review to the original patch in this thread.
We take the discussion there.

>>>> Of course, I address all such issues that I can think of, in my implementation.
>>>
>>> Ok, I'll rely on acked-by's from the interested parties once your
>>> driver is out as I do not have a vested interest in this hardware,
>>> just the dmaengine framework issues.
>> Fair enough. Thank you.
>
> As your previous mail, we can wait until this weekend. but If you
> don't post the your codes until this weekend.
> We assume that your works are not yet done so merge this patch first
> and then fix it if your words(DMA aborts issue) are right.
It's not upto you to give me any deadline. Not the "Until this weekend" one !!!
I think only the word of the maintainers count.