From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645Ab0CZAsm (ORCPT ); Thu, 25 Mar 2010 20:48:42 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:41996 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085Ab0CZAsl (ORCPT ); Thu, 25 Mar 2010 20:48:41 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=apzlOCZPO2TwZdUfAEEUGSrSiJlDwOH6oSqtjkTOAwaioSA3jBFhKDOz6S6Tmnn8oZ gP09sSSacFzeHCS+V6dYQRZqaKk1zMpx9+M4PiWjSP7zMwFXvKAGtnKQbUbYu/3mi/UK 5fInOQokdXhgEOWSNBq7offHxgO+eGRKg68vI= MIME-Version: 1.0 In-Reply-To: <9c9fda241003251729y28ccbadfs7ac72ad99b6d6ffa@mail.gmail.com> References: <4BAAD5BB.7050101@samsung.com> <1b68c6791003242234h106d9530p12b5a046a906227e@mail.gmail.com> <63386a3d1003250130w6f34854ag2ca163799e9b7bed@mail.gmail.com> <1b68c6791003250517y4e2789baoe147e5982c363682@mail.gmail.com> <4BAB7D9F.4070807@intel.com> <1b68c6791003251527s1ef985d2m4a309a3c09e31e0a@mail.gmail.com> <1b68c6791003251659w4c6c8d12rf97458c2380f25e0@mail.gmail.com> <9c9fda241003251729y28ccbadfs7ac72ad99b6d6ffa@mail.gmail.com> Date: Fri, 26 Mar 2010 09:48:40 +0900 Message-ID: <1b68c6791003251748r1688ffceyb1494dfef8434bb0@mail.gmail.com> Subject: Re: [PATCH v2] PL330: Add PL330 DMA controller driver From: jassi brar To: Kyungmin Park Cc: Dan Williams , Russell King - ARM Linux , Joonyoung Shim , Linus Walleij , "linux-kernel@vger.kernel.org" , Ben Dooks , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2010 at 9:29 AM, Kyungmin Park wrote: > On Fri, Mar 26, 2010 at 8:59 AM, jassi brar wrote: >> On Fri, Mar 26, 2010 at 8:12 AM, Dan Williams wrote: >>> On Thu, Mar 25, 2010 at 3:27 PM, jassi brar wrote: >>>> On Fri, Mar 26, 2010 at 12:13 AM, Dan Williams wrote: >>>>> It sounds like you just need to add an extension for the arch specific dma >>>>> api. >>>> I actually plan more than that. >>>> Apart from inefficient design, JoonYoung's driver has made some fatal >>>> assumptions >>>> about PL330, which will result in DMA aborts if used with SoCs that implement >>>> configuration of PL330 that is very different from Samsung SoCs' > Exactly what? We are already tested it our board and play the music well. > What's condition DMA aborts are happen? I didn't want to get into gory details, but it seems I need to explain ..... Please see my quick review to the original patch in this thread. We take the discussion there. >>>> Of course, I address all such issues that I can think of, in my implementation. >>> >>> Ok, I'll rely on acked-by's from the interested parties once your >>> driver is out as I do not have a vested interest in this hardware, >>> just the dmaengine framework issues. >> Fair enough. Thank you. > > As your previous mail, we can wait until this weekend. but If you > don't post the your codes until this weekend. > We assume that your works are not yet done so merge this patch first > and then fix it if your words(DMA aborts issue) are right. It's not upto you to give me any deadline. Not the "Until this weekend" one !!! I think only the word of the maintainers count.