public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Joel Stanley" <joel@jms.id.au>, "Jeremy Kerr" <jk@ozlabs.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: Alistar Popple <alistair@popple.id.au>,
	linux-fsi@lists.ozlabs.org, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
Date: Wed, 16 Aug 2023 13:33:01 -0500	[thread overview]
Message-ID: <1b841ade-20c0-d239-d8ae-2bb4426fefa8@linux.ibm.com> (raw)
In-Reply-To: <20230816171944.123705-1-u.kleine-koenig@pengutronix.de>


On 8/16/23 12:19, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.


Thanks!


Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.
>
> Thanks
> Uwe
>
>   drivers/fsi/fsi-master-i2cr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
>   MODULE_DEVICE_TABLE(of, i2cr_ids);
>   
>   static struct i2c_driver i2cr_driver = {
> -	.probe_new = i2cr_probe,
> +	.probe = i2cr_probe,
>   	.remove = i2cr_remove,
>   	.driver = {
>   		.name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b

  reply	other threads:[~2023-08-16 18:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 17:19 [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe() Uwe Kleine-König
2023-08-16 18:33 ` Eddie James [this message]
2023-08-21  4:57 ` Joel Stanley
2023-08-21  5:48   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b841ade-20c0-d239-d8ae-2bb4426fefa8@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=gregkh@linuxfoundation.org \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=kernel@pengutronix.de \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox