From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4253FC433F5 for ; Thu, 17 Mar 2022 14:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235014AbiCQOVG (ORCPT ); Thu, 17 Mar 2022 10:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234774AbiCQOVA (ORCPT ); Thu, 17 Mar 2022 10:21:00 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A82169B0A for ; Thu, 17 Mar 2022 07:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647526783; x=1679062783; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=U6rXM0bflcprHQwN2TgyP68VKWMmXe8T0RivNVIeLO4=; b=XhK0/ma0fVMn+oC1IzUwE3L/NdYquly8fiLkmLs3cd3Ng1bfzdlxzk6j QsvH6g399I7I1nGmWRS47af6i4Fmi/Moe7enHxzmn3ocqX+7cbYX8tqeI +VXiXat/Z9iUZJVLQz4RO0iuDzN3rHXL5v7ysx3pIl/PBAsGx5rYbDFou K87dQ2c8QGfooFsnoQ1jVW1wlsbxGizFFTN9S0ETsmb/XEVovuvuKmHiE ChJst1gfoO6FPXW2QZDo+rTsAio5laPKb7qQBeQfH75c/m0g26gFhNYf0 6GtYXGGUqTDauQL+gPeX+pBPM/KWJIRetIvA6Cvx5x2TWvyOuIRkAkiWa A==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="320089294" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="320089294" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 07:19:42 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="541385197" Received: from knavalgu-mobl1.gar.corp.intel.com (HELO [10.251.29.221]) ([10.251.29.221]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 07:19:41 -0700 Message-ID: <1b955086-94d0-d524-4cd4-b177df56f71c@linux.intel.com> Date: Thu, 17 Mar 2022 08:21:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH] ASoC: SOF: topology: Use kmemdup() to replace kzalloc + memcpy Content-Language: en-US To: Yihao Han , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: kernel@vivo.com References: <20220317093841.3414-1-hanyihao@vivo.com> From: Pierre-Louis Bossart In-Reply-To: <20220317093841.3414-1-hanyihao@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/22 04:38, Yihao Han wrote: > fix memdup.cocci warning: > sound/soc/sof/topology.c:876:19-26: WARNING opportunity for kmemdup > > Generated by: scripts/coccinelle/api/memdup.cocci > > Signed-off-by: Yihao Han Thanks for the patch Acked-by: Pierre-Louis Bossart > --- > sound/soc/sof/topology.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c > index 367fbe2d5b31..369693cc6d10 100644 > --- a/sound/soc/sof/topology.c > +++ b/sound/soc/sof/topology.c > @@ -873,11 +873,10 @@ static int sof_control_load_bytes(struct snd_soc_component *scomp, > > /* copy the private data */ > if (priv_size > 0) { > - scontrol->priv = kzalloc(priv_size, GFP_KERNEL); > + scontrol->priv = kmemdup(control->priv.data, priv_size, GFP_KERNEL); > if (!scontrol->priv) > return -ENOMEM; > > - memcpy(scontrol->priv, control->priv.data, priv_size); > scontrol->priv_size = priv_size; > } >