From: Felix Fietkau <nbd@nbd.name>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: add support for segmenting TCP fraglist GSO packets
Date: Thu, 25 Apr 2024 09:51:12 +0200 [thread overview]
Message-ID: <1bc0ac3d-b18d-4969-a090-6803fa4dd5b4@nbd.name> (raw)
In-Reply-To: <6629c805d808e_1bd6b029424@willemb.c.googlers.com.notmuch>
On 25.04.24 05:03, Willem de Bruijn wrote:
> Felix Fietkau wrote:
>> Preparation for adding TCP fraglist GRO support. It expects packets to be
>> combined in a similar way as UDP fraglist GSO packets.
>> One difference is the fact that this code assumes that the TCP flags of
>> all packets have the same value. This allows simple handling of flags
>> mutations.
>
> Can you clarify this some more? We expect potentially different flags
> on first and last packet in a TSO train. With fraglist, the segments
> keep their original flags, as the headers are only pulled. When do
> segment flags need to be replaced with those of the first segment?
Maybe I just misunderstood a comment that Paolo made earlier regarding
TCP header mutations. Will review this again and compare with regular TSO.
- Felix
next prev parent reply other threads:[~2024-04-25 7:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240424180458.56211-1-nbd@nbd.name>
2024-04-24 18:04 ` [PATCH net-next 1/4] net: move skb_gro_receive_list from udp to core Felix Fietkau
2024-04-24 18:04 ` [PATCH net-next 2/4] net: add support for segmenting TCP fraglist GSO packets Felix Fietkau
2024-04-25 3:03 ` Willem de Bruijn
2024-04-25 7:51 ` Felix Fietkau [this message]
2024-04-26 8:00 ` Paolo Abeni
2024-04-24 18:04 ` [PATCH net-next 3/4] net: add code for TCP fraglist GRO Felix Fietkau
2024-04-26 8:14 ` Paolo Abeni
2024-04-24 18:04 ` [PATCH net-next 4/4] net: add heuristic for enabling " Felix Fietkau
2024-04-24 18:23 ` Eric Dumazet
2024-04-24 18:48 ` Felix Fietkau
2024-04-25 7:44 ` kernel test robot
2024-04-25 9:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc0ac3d-b18d-4969-a090-6803fa4dd5b4@nbd.name \
--to=nbd@nbd.name \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox